This repository was archived by the owner on May 1, 2025. It is now read-only.
DOCSP-47288: Rename some enableUserWriteBlocking internal-only options and disallow live upgrade to 1.12
#611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nvillahermosa-mdb
approved these changes
Feb 12, 2025
ajayvijayakumar123
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
LGTM % one small suggestion! Also tagging @mvankeulen94 for input
source/includes/live-upgrade.rst
Outdated
|
|
||
| .. important:: | ||
|
|
||
| ``mongosync`` does not support live upgrades to version 1.11. | ||
| ``mongosync`` does not support live upgrades to version 1.11 or 1.12. |
There was a problem hiding this comment.
Suggested change
| ``mongosync`` does not support live upgrades to version 1.11 or 1.12. | |
| ``mongosync`` does not support live upgrades to version 1.12. |
I think this is simpler
There was a problem hiding this comment.
@mvankeulen94 does this get a LGTM from you as well?
5 tasks
|
@mayaraman19 , I got approval from Felipe Gaspar via Slack for the main release notes PR. Since this PR already has a dev LGTM, and C2C 1.12 is due to release today, I think we're good to merge. |
FGasper
suggested changes
Feb 19, 2025
source/reference/api/start.txt
Outdated
Comment on lines
122
to
131
| - ``true`` or ``"sourceAndDestination"``: blocks writes on the destination | ||
| cluster while the migration is in progress, and unblocks writes right | ||
| before the :ref:`/progress <c2c-api-progress>` endpoint reports | ||
| that ``canWrite`` is ``true``. Blocks writes on the source | ||
| cluster after ``mongosync`` calls the :ref:`/commit <c2c-api-commit>` | ||
| endpoint. | ||
|
|
||
| :gold:`IMPORTANT:` If you are migrating from a pre-6.0 source cluster, | ||
| you cannot set ``enableUserWriteBlocking`` to ``true`` or | ||
| ``"sourceAndDestination"``. |
There was a problem hiding this comment.
We want people to use the string rather than the bool, which is just left in for backward compatibility.
Maybe:
Suggested change
| - ``true`` or ``"sourceAndDestination"``: blocks writes on the destination | |
| cluster while the migration is in progress, and unblocks writes right | |
| before the :ref:`/progress <c2c-api-progress>` endpoint reports | |
| that ``canWrite`` is ``true``. Blocks writes on the source | |
| cluster after ``mongosync`` calls the :ref:`/commit <c2c-api-commit>` | |
| endpoint. | |
| :gold:`IMPORTANT:` If you are migrating from a pre-6.0 source cluster, | |
| you cannot set ``enableUserWriteBlocking`` to ``true`` or | |
| ``"sourceAndDestination"``. | |
| - ``"sourceAndDestination"``: blocks writes on the destination | |
| cluster while the migration is in progress, and unblocks writes right | |
| before the :ref:`/progress <c2c-api-progress>` endpoint reports | |
| that ``canWrite`` is ``true``. Blocks writes on the source | |
| cluster after ``mongosync`` calls the :ref:`/commit <c2c-api-commit>` | |
| endpoint. | |
| :gold:`IMPORTANT:` If you are migrating from a pre-6.0 source cluster, | |
| you cannot set this value. | |
| For legacy compatibility, ``true`` is another way to express this option. |
source/reference/api/start.txt
Outdated
| you cannot set ``enableUserWriteBlocking`` to ``true`` or | ||
| ``"sourceAndDestination"``. | ||
|
|
||
| - ``false`` or ``"none"``: no write blocking occurs. |
There was a problem hiding this comment.
Suggested change
| - ``false`` or ``"none"``: no write blocking occurs. | |
| - ``"none"``: no write blocking occurs. | |
| For legacy compatibility, ``false`` is another way to express this option. |
source/reference/api/start.txt
Outdated
| to ``true``. To allow the source cluster to accept writes again, | ||
| for example after running migration tests, run the following | ||
| command: | ||
| to ``true`` or ``"sourceAndDestination"``. To allow the source cluster |
There was a problem hiding this comment.
Suggested change
| to ``true`` or ``"sourceAndDestination"``. To allow the source cluster | |
| to ``"sourceAndDestination"``. To allow the source cluster |
FGasper
suggested changes
Feb 19, 2025
Comment on lines
31
to
33
| - You can't set the ``enableUserWriteBlocking`` option to ``true`` or | ||
| ``"sourceAndDestination"`` in the ``/start`` request, so dual write-blocking | ||
| is not supported. |
There was a problem hiding this comment.
Suggested change
| - You can't set the ``enableUserWriteBlocking`` option to ``true`` or | |
| ``"sourceAndDestination"`` in the ``/start`` request, so dual write-blocking | |
| is not supported. | |
| - You can't set the ``enableUserWriteBlocking`` option to | |
| ``"sourceAndDestination"`` in the ``/start`` request, so dual write-blocking | |
| is not supported. |
|
|
||
| - ``"sourceAndDestination"`` for dual write-blocking | ||
| - ``"none"`` for no write-blocking | ||
|
|
There was a problem hiding this comment.
Suggested change
| These options are identical to the old `true` and `false` values. The old values remain for backward compatibility. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
enableUserWriteBlockingparams and disallows live upgrade to 1.12. Also updates most mentions ofenableUserWriteBlockingparams to use the strings.https://jira.mongodb.org/browse/DOCSP-47288
Staging: