Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

DOCSP-47695-remove-live-upgrade #628

Merged
merged 8 commits into from
Feb 28, 2025
Merged

Conversation

ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Feb 19, 2025

DESCRIPTION

Remove mentions of live upgrades

STAGING

https://deploy-preview-628--docs-cluster-to-cluster-sync.netlify.app/reference/versioning/
https://deploy-preview-628--docs-cluster-to-cluster-sync.netlify.app/reference/api/progress/#behavior
https://deploy-preview-628--docs-cluster-to-cluster-sync.netlify.app/release-notes/1.11/#live-upgrades
https://deploy-preview-628--docs-cluster-to-cluster-sync.netlify.app/reference/live-upgrade/#std-label-c2c-live-upgrade

JIRA

https://jira.mongodb.org/browse/DOCSP-47695

SELF-REVIEW CHECKLIST

  • Does each file have 3-5 taxonomy facet tags?
    See the taxonomy tagging instructions and this example PR
  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

EXTERNAL REVIEW REQUIREMENTS

What's expected of an external reviewer?

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 922de04
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67c20dfcd4498700080f8229
😎 Deploy Preview https://deploy-preview-628--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@amalhotra-mdb amalhotra-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @ltran-mdb2 , LGTM!

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question! Also tagging @mvankeulen94

@@ -30,8 +30,7 @@ Destination-Only Write-Blocking
Live Upgrades
~~~~~~~~~~~~~

:ref:`Live upgrades <c2c-versioning-live-upgrade>`
to version 1.11 are not supported.
Starting in version 1.11.0, ``mongosync`` does not support live upgrades.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to keep the live upgrade page around but only include this link to it? (i.e. an orphaned page)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created an orphaned page with the live upgrade information!

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! just one comment


.. important::

Starting in version 1.11.0, ``mongosync`` does not support live upgrades. To

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would instead say something like, Live Upgrade to mongosync 1.11 onwards is not supported, due to expanded permissions required for mongosync 1.11.
Initially we didn't want to get into the specific versions but after further consideration I think it's necessary to avoid sounding like we've gotten rid of Live Upgrade altogether. cc @ajayvijayakumar123 lmk if that messaging sounds good to you, thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup sounds good!

@ltran-mdb2 ltran-mdb2 merged commit 474fff0 into mongodb:master Feb 28, 2025
3 of 4 checks passed
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Feb 28, 2025
* DOCSP-47695-remove-live-upgrade

* DOCSP-47695-remove-live-upgrade

* DOCSP-47695-remove-live-upgrade

* DOCSP-47695 adding noindex page

* DOCSP-47695 adding noindex page

* DOCSP-47695 Maria comment

* DOCSP-47695 copy edits

(cherry picked from commit 474fff0)

# Conflicts:
#	source/reference/versioning.txt
@ltran-mdb2
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.11

Questions ?

Please refer to the Backport tool documentation

ltran-mdb2 added a commit that referenced this pull request Feb 28, 2025
* DOCSP-47695-remove-live-upgrade

* DOCSP-47695-remove-live-upgrade

* DOCSP-47695-remove-live-upgrade

* DOCSP-47695 adding noindex page

* DOCSP-47695 adding noindex page

* DOCSP-47695 Maria comment

* DOCSP-47695 copy edits

(cherry picked from commit 474fff0)

# Conflicts:
#	source/reference/versioning.txt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants