-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up @ltran-mdb2 , LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 question! Also tagging @mvankeulen94
source/release-notes/1.11.txt
Outdated
@@ -30,8 +30,7 @@ Destination-Only Write-Blocking | |||
Live Upgrades | |||
~~~~~~~~~~~~~ | |||
|
|||
:ref:`Live upgrades <c2c-versioning-live-upgrade>` | |||
to version 1.11 are not supported. | |||
Starting in version 1.11.0, ``mongosync`` does not support live upgrades. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to keep the live upgrade page around but only include this link to it? (i.e. an orphaned page)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just created an orphaned page with the live upgrade information!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! just one comment
source/reference/live-upgrade.txt
Outdated
|
||
.. important:: | ||
|
||
Starting in version 1.11.0, ``mongosync`` does not support live upgrades. To |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would instead say something like, Live Upgrade to mongosync 1.11 onwards is not supported, due to expanded permissions required for mongosync 1.11.
Initially we didn't want to get into the specific versions but after further consideration I think it's necessary to avoid sounding like we've gotten rid of Live Upgrade altogether. cc @ajayvijayakumar123 lmk if that messaging sounds good to you, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup sounds good!
82b47a1
to
cb5936d
Compare
d16b506
to
309d745
Compare
* DOCSP-47695-remove-live-upgrade * DOCSP-47695-remove-live-upgrade * DOCSP-47695-remove-live-upgrade * DOCSP-47695 adding noindex page * DOCSP-47695 adding noindex page * DOCSP-47695 Maria comment * DOCSP-47695 copy edits (cherry picked from commit 474fff0) # Conflicts: # source/reference/versioning.txt
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* DOCSP-47695-remove-live-upgrade * DOCSP-47695-remove-live-upgrade * DOCSP-47695-remove-live-upgrade * DOCSP-47695 adding noindex page * DOCSP-47695 adding noindex page * DOCSP-47695 Maria comment * DOCSP-47695 copy edits (cherry picked from commit 474fff0) # Conflicts: # source/reference/versioning.txt
DESCRIPTION
Remove mentions of live upgrades
STAGING
https://deploy-preview-628--docs-cluster-to-cluster-sync.netlify.app/reference/versioning/
https://deploy-preview-628--docs-cluster-to-cluster-sync.netlify.app/reference/api/progress/#behavior
https://deploy-preview-628--docs-cluster-to-cluster-sync.netlify.app/release-notes/1.11/#live-upgrades
https://deploy-preview-628--docs-cluster-to-cluster-sync.netlify.app/reference/live-upgrade/#std-label-c2c-live-upgrade
JIRA
https://jira.mongodb.org/browse/DOCSP-47695
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?