This repository was archived by the owner on May 1, 2025. It is now read-only.
DOCSP-48421-clarify-verifier-lag-time #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @autarch , could you take a look at this PR for a review, whenever you get a chance? Thanks! |
autarch
suggested changes
Mar 18, 2025
Comment on lines
56
to
60
| With the introduction of the :ref:`embdedded verfier<c2c-embedded-verifier>` | ||
| in version 1.9, there are now three different ``lagTimeSeconds`` fields: | ||
| - ``lagTimeSeconds`` for ``mongosync`` | ||
| - ``lagTimeSeconds`` for the source cluster for the verifier | ||
| - ``lagTimeSeconds`` for the destination cluster for the verifier |
There was a problem hiding this comment.
We should probably specify that there are 3 fields when embedded verification is enabled. Otherwise, there's just one.
There was a problem hiding this comment.
Thanks @autarch , update made! Back to you.
gmiller-mdb
reviewed
Mar 18, 2025
Comment on lines
58
to
61
| embedded verification is enabled: | ||
| - ``lagTimeSeconds`` for ``mongosync`` | ||
| - ``lagTimeSeconds`` for the source cluster for the verifier | ||
| - ``lagTimeSeconds`` for the destination cluster for the verifier |
There was a problem hiding this comment.
This is not rendering right in the table
|
Thanks @gmiller-mdb ! Back to you! |
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Mar 19, 2025
* DOCSP-48421-clarify-verifier-lag-time * build error * reviewer update * fix render (cherry picked from commit 3fb8e0b)
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Mar 19, 2025
* DOCSP-48421-clarify-verifier-lag-time * build error * reviewer update * fix render (cherry picked from commit 3fb8e0b)
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Mar 19, 2025
* DOCSP-48421-clarify-verifier-lag-time * build error * reviewer update * fix render (cherry picked from commit 3fb8e0b)
amalhotra-mdb
added a commit
to amalhotra-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Mar 19, 2025
* DOCSP-48421-clarify-verifier-lag-time * build error * reviewer update * fix render (cherry picked from commit 3fb8e0b)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
amalhotra-mdb
added a commit
that referenced
this pull request
Mar 19, 2025
amalhotra-mdb
added a commit
that referenced
this pull request
Mar 19, 2025
amalhotra-mdb
added a commit
that referenced
this pull request
Mar 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Clarifies that there are 3 diff
lagTimeSecondsfields in theprogressresponse in the progress page & commit page.STAGING
JIRA
https://jira.mongodb.org/browse/DOCSP-48421
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?