-
Notifications
You must be signed in to change notification settings - Fork 35
DOCSP-48609-add-mongosync-notes #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-48609-add-mongosync-notes #691
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates @gmiller-mdb. Left a few comments for you to address before this can go to external!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these fixes @gmiller-mdb! Just a couple smaller nits to iron out for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM technically. I thought “config shard” was the preferred term for this, rather than “embedded config server shards”, but that’s up to you folks. :)
@@ -179,6 +179,17 @@ primary shard to each database by means of a round-robin. | |||
restart the migration from the start. For more information, see | |||
:ref:`c2c-sharded-limitations`. | |||
|
|||
Embedded Config Server Shards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a new term? I thought the term was just “config shard”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FGasper that was the language that the ticket used, I'll ask the person who created it before I publish!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, Felipe! I'm fine to change the language to Config Shard cluster and link to that page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvankeulen94 just made the changes! would you mind taking a last look? thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! sorry for the back and forth on this. added some final comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! just one small change and I'm good to lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
* DOCSP-48609-add-mongosync-notes * copy * move section * feedback * nits * feedback * feedback * add (cherry picked from commit db46be3)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* DOCSP-48609-add-mongosync-notes * copy * move section * feedback * nits * feedback * feedback * add (cherry picked from commit db46be3)
https://deploy-preview-691--docs-cluster-to-cluster-sync.netlify.app/reference/mongosync/mongosync-behavior/#embedded-config-server-shards
https://deploy-preview-691--docs-cluster-to-cluster-sync.netlify.app/reference/limitations/#sharded-clusters
https://jira.mongodb.org/browse/DOCSP-48609