Skip to content

DOCSP-48609-add-mongosync-notes #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit d6bb86e
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67e552bebd5a3d00088e7313
😎 Deploy Preview https://deploy-preview-691--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates @gmiller-mdb. Left a few comments for you to address before this can go to external!

@gmiller-mdb gmiller-mdb requested a review from ajhuh-mdb March 24, 2025 19:41
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes @gmiller-mdb! Just a couple smaller nits to iron out for clarity.

@gmiller-mdb gmiller-mdb requested a review from ajhuh-mdb March 24, 2025 21:35
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

Copy link
Contributor

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM technically. I thought “config shard” was the preferred term for this, rather than “embedded config server shards”, but that’s up to you folks. :)

@@ -179,6 +179,17 @@ primary shard to each database by means of a round-robin.
restart the migration from the start. For more information, see
:ref:`c2c-sharded-limitations`.

Embedded Config Server Shards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new term? I thought the term was just “config shard”.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FGasper that was the language that the ticket used, I'll ask the person who created it before I publish!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@mvankeulen94 mvankeulen94 Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, Felipe! I'm fine to change the language to Config Shard cluster and link to that page

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvankeulen94 just made the changes! would you mind taking a last look? thanks!

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! sorry for the back and forth on this. added some final comments

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! just one small change and I'm good to lgtm

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@gmiller-mdb gmiller-mdb merged commit db46be3 into mongodb:master Mar 27, 2025
4 checks passed
gmiller-mdb added a commit to gmiller-mdb/docs-cluster-to-cluster-sync that referenced this pull request Mar 27, 2025
* DOCSP-48609-add-mongosync-notes

* copy

* move section

* feedback

* nits

* feedback

* feedback

* add

(cherry picked from commit db46be3)
@gmiller-mdb
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.11
v1.10

Questions ?

Please refer to the Backport tool documentation

gmiller-mdb added a commit to gmiller-mdb/docs-cluster-to-cluster-sync that referenced this pull request Mar 27, 2025
* DOCSP-48609-add-mongosync-notes

* copy

* move section

* feedback

* nits

* feedback

* feedback

* add

(cherry picked from commit db46be3)
gmiller-mdb added a commit that referenced this pull request Mar 27, 2025
* DOCSP-48609-add-mongosync-notes

* copy

* move section

* feedback

* nits

* feedback

* feedback

* add

(cherry picked from commit db46be3)
gmiller-mdb added a commit that referenced this pull request Mar 27, 2025
* DOCSP-48609-add-mongosync-notes

* copy

* move section

* feedback

* nits

* feedback

* feedback

* add

(cherry picked from commit db46be3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants