Skip to content

DOCSP-36900: Quarterly tasks #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Feb 16, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-36900
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/golang/DOCSP-36900-go-atomic-typos/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@rachel-mack rachel-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions:

@@ -176,7 +176,7 @@ the following documents:

You can sort on additional fields to resolve ties in the original sort.
If you want to guarantee a specific order for documents, you should
select sort fields that will not result in additional ties.
select sort fields that do not result in more ties.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Reads clearner.

Suggested change
select sort fields that do not result in more ties.
select sort fields that do not result in ties.

Comment on lines +67 to +69
Specify your MongoDB Atlas connection string as the value of the
``uri`` variable, or create an environment variable called
``MONGODB_URI`` and set your Atlas connection string as its value.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: You could add a link to the Atlas instructions for creating/finding a connection string.

@norareidy norareidy merged commit 4b0ba1f into mongodb:master Feb 20, 2024
@norareidy norareidy deleted the DOCSP-36900-go-atomic-typos branch February 20, 2024 16:56
norareidy added a commit that referenced this pull request Feb 20, 2024
* DOCSP-36900: Quarterly tasks

* more fixes

* vale fix

* RM feedback

* remove info

(cherry picked from commit 4b0ba1f)
norareidy added a commit that referenced this pull request Feb 20, 2024
* DOCSP-36900: Quarterly tasks

* more fixes

* vale fix

* RM feedback

* remove info

(cherry picked from commit 4b0ba1f)
norareidy added a commit that referenced this pull request Feb 20, 2024
* DOCSP-36900: Quarterly tasks

* more fixes

* vale fix

* RM feedback

* remove info

(cherry picked from commit 4b0ba1f)
norareidy added a commit that referenced this pull request Feb 20, 2024
* DOCSP-36900: Quarterly tasks

* more fixes

* vale fix

* RM feedback

* remove info

(cherry picked from commit 4b0ba1f)
rustagir pushed a commit to rustagir/docs-golang that referenced this pull request Feb 26, 2024
* DOCSP-36900: Quarterly tasks

* more fixes

* vale fix

* RM feedback

* remove info

(cherry picked from commit 4b0ba1f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants