DOCSP-38345: session converted to struct #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
requested changes
May 13, 2024
source/fundamentals/transactions.txt
Outdated
| @@ -58,7 +58,7 @@ Methods | |||
| ------- | |||
|
|
|||
| After you start a session by using the ``StartSession()`` method, you can modify | |||
| the session state by using the method set provided by the ``Session`` interface. The | |||
| the session state by using the method set provided by the ``Session`` struct. The | |||
There was a problem hiding this comment.
The type here isn't as important as the name. Consider referring to the value by name.
Suggested change
| the session state by using the method set provided by the ``Session`` struct. The | |
| the session state by using the method set provided by the returned ``Session``. The |
source/fundamentals/transactions.txt
Outdated
| @@ -123,7 +123,7 @@ following table describes these methods: | |||
| | **Parameter**: ``Context`` | |||
| | **Return Type**: none | |||
|
|
|||
| The ``Session`` interface also has methods to retrieve session | |||
| The ``Session`` struct also has methods to retrieve session | |||
There was a problem hiding this comment.
Similar to above, the type isn't important to the description of the behavior. Consider referring to the value by name.
Suggested change
| The ``Session`` struct also has methods to retrieve session | |
| A ``Session`` also has methods to retrieve session |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-38345
Staging
Self-Review Checklist