DOCSP-42256: leftover v2 migration items #377
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-smith721
approved these changes
Aug 8, 2024
source/whats-new.txt
Outdated
Comment on lines
126
to
128
| ``Cursor.SetMaxAwaitTime()``. This method specifies the maximum time | ||
| that the server waits for new documents when you retrieve documents by | ||
| using a tailable cursor when querying a capped collection. |
There was a problem hiding this comment.
S: This is a pretty wordy sentence. Can it be simplified to something like:
Suggested change
| ``Cursor.SetMaxAwaitTime()``. This method specifies the maximum time | |
| that the server waits for new documents when you retrieve documents by | |
| using a tailable cursor when querying a capped collection. | |
| ``Cursor.SetMaxAwaitTime()``. This method specifies the maximum time | |
| that the server waits for new documents when retrieving documents with a tailable cursor on a capped collection. |
source/whats-new.txt
Outdated
| @@ -122,6 +122,13 @@ The 2.0 {+driver-short+} release includes the following improvements and fixes: | |||
| ``SessionOptions`` type. To learn more, see the | |||
| :ref:`golang-session-txn-options` section of the Transactions guide. | |||
|
|
|||
| - The ``Cursor.SetMaxTime()`` method is renamed to | |||
There was a problem hiding this comment.
Q: Is this a breaking change since it changes a method name?
|
@prestonvasquez reminder for you to review! |
prestonvasquez
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42256
Staging - https://preview-mongodbrustagir.gatsbyjs.io/golang/DOCSP-42256-v2-mig-items/whats-new/
Self-Review Checklist