Skip to content

DOCSP-48094: BOM #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 31, 2025
Merged

DOCSP-48094: BOM #663

merged 9 commits into from
Mar 31, 2025

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Mar 24, 2025 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48094

Staging Links

instructions
whats new

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Mar 24, 2025 •
edited
Loading

✅ Deploy Preview for docs-java ready!

Name Link
🔨 Latest commit 7e7cc91
🔍 Latest deploy log https://app.netlify.com/sites/docs-java/deploys/67eaf810d7e83700085e4ee1
😎 Deploy Preview https://deploy-preview-663--docs-java.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir marked this pull request as ready for review March 24, 2025 19:23
@rustagir rustagir requested a review from rozza March 24, 2025 19:24
rustagir
rustagir commented Mar 24, 2025
View reviewed changes
@rustagir rustagir requested a review from vbabanin March 24, 2025 20:16
mongoKart
mongoKart approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ a Q and small fix

rozza
rozza approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. - will this be added to the reactive streams and kotlin drivers as well?

@rustagir rustagir merged commit 8f788e6 into mongodb:master Mar 31, 2025
5 checks passed
rustagir added a commit that referenced this pull request Mar 31, 2025
@rustagir
DOCSP-48094: BOM (#663)
485792c 
* DOCSP-48094: BOM

* small fix

* small fix

* fixes

* implement sharedinclude

* fix link

(cherry picked from commit 8f788e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozza rozza rozza approved these changes

@mongoKart mongoKart mongoKart approved these changes

@vbabanin vbabanin Awaiting requested review from vbabanin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustagir @rozza @mongoKart