Skip to content

DOCSP-45186: Insert #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Dec 13, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45186

Staging Links

  • write/insert
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Dec 13, 2024

    Deploy Preview for docs-ruby ready!

    Name Link
    🔨 Latest commit d8cb575
    🔍 Latest deploy log https://app.netlify.com/sites/docs-ruby/deploys/675c86ae2cc27a000819cbc0
    😎 Deploy Preview https://deploy-preview-101--docs-ruby.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm with minor suggestions!

    -------------------------

    To add multiple documents to a MongoDB collection, call the ``insert_many``
    function and pass a list of documents you want to insert.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: I think "method" is more accurate for Ruby, based on the existing docs (and google)

    Suggested change
    function and pass a list of documents you want to insert.
    method and pass a list of documents you want to insert.

    :widths: 30 70
    :header-rows: 1

    * - Method
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: I'd use "Option" or "Setting" instead

    Suggested change
    * - Method
    * - Option

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I missed this one, good catch!

    * - ``comment``
    - | Sets a comment to attach to the operation. For more information, see the :manual:`insert command
    fields </reference/command/insert/#command-fields>` guide in the
    {+mdb-server+} manual for more information.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: remove the repeated info

    Suggested change
    {+mdb-server+} manual for more information.
    {+mdb-server+} manual.

    Comment on lines 124 to 126
    - | Instructs the driver whether or not to ignore
    :manual:`document-level validation </core/schema-validation>`.
    | Defaults to ``false``.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: instead of inline linking to the Server page, you could use the same "For more information ..." syntax as the other table descriptions (applies to write_concern too)

    Suggested change
    - | Instructs the driver whether or not to ignore
    :manual:`document-level validation </core/schema-validation>`.
    | Defaults to ``false``.
    - | Instructs the driver whether or not to ignore document-level
    validation. For more information, see
    :manual:`Schema Validation </core/schema-validation>`.
    in the {+mdb-server+} manual.
    | Defaults to ``false``.

    @mcmorisi mcmorisi merged commit 072c5d8 into mongodb:standardization Dec 16, 2024
    5 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-45186-insert branch December 16, 2024 13:54
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants