-
Notifications
You must be signed in to change notification settings - Fork 28
DOCSP-45186: Insert #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-45186: Insert #101
Conversation
✅ Deploy Preview for docs-ruby ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with minor suggestions!
source/write/insert.txt
Outdated
------------------------- | ||
|
||
To add multiple documents to a MongoDB collection, call the ``insert_many`` | ||
function and pass a list of documents you want to insert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: I think "method" is more accurate for Ruby, based on the existing docs (and google)
function and pass a list of documents you want to insert. | |
method and pass a list of documents you want to insert. |
source/write/insert.txt
Outdated
:widths: 30 70 | ||
:header-rows: 1 | ||
|
||
* - Method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: I'd use "Option" or "Setting" instead
* - Method | |
* - Option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this one, good catch!
source/write/insert.txt
Outdated
* - ``comment`` | ||
- | Sets a comment to attach to the operation. For more information, see the :manual:`insert command | ||
fields </reference/command/insert/#command-fields>` guide in the | ||
{+mdb-server+} manual for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: remove the repeated info
{+mdb-server+} manual for more information. | |
{+mdb-server+} manual. |
source/write/insert.txt
Outdated
- | Instructs the driver whether or not to ignore | ||
:manual:`document-level validation </core/schema-validation>`. | ||
| Defaults to ``false``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: instead of inline linking to the Server page, you could use the same "For more information ..." syntax as the other table descriptions (applies to write_concern too)
- | Instructs the driver whether or not to ignore | |
:manual:`document-level validation </core/schema-validation>`. | |
| Defaults to ``false``. | |
- | Instructs the driver whether or not to ignore document-level | |
validation. For more information, see | |
:manual:`Schema Validation </core/schema-validation>`. | |
in the {+mdb-server+} manual. | |
| Defaults to ``false``. |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45186
Staging Links
Self-Review Checklist