Skip to content

DOCSP-45209: Authentication landing + Authentication mechanisms #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 17, 2025
Merged

DOCSP-45209: Authentication landing + Authentication mechanisms #127

merged 17 commits into from
Jan 17, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jan 14, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45209

Staging Links

  • security
  • security/auth-mechanisms/aws-iam
  • security/auth-mechanisms/kerberos
  • security/auth-mechanisms/ldap
  • security/auth-mechanisms/scram
  • security/auth-mechanisms/x509
  • security/authentication
  • index

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Jan 14, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-ruby ready!

    Name Link
    🔨 Latest commit 582daa8
    🔍 Latest deploy log https://app.netlify.com/sites/docs-ruby/deploys/678ab830cb6ba70008e8499a
    😎 Deploy Preview https://deploy-preview-127--docs-ruby.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    mcmorisi
    mcmorisi commented Jan 14, 2025
    View reviewed changes
    mcmorisi
    mcmorisi commented Jan 14, 2025
    View reviewed changes
    source/authentication/kerberos.txt Outdated
    @@ -0,0 +1,93 @@
    .. _ruby-authentication-kerberos:
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This page is pulled from the Kerberos section in the existing Ruby docs.

    @mcmorisi mcmorisi requested a review from mongoKart January 14, 2025 17:31
    mongoKart
    mongoKart requested changes Jan 15, 2025
    View reviewed changes
    Copy link
    Collaborator

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    there were enough comments that i thought we should break this up into multiple reviews. overall, awesome job! i know there was more to this than initially expected. lmk if you have questions or want to pair on anything

    @mcmorisi mcmorisi requested a review from mongoKart January 15, 2025 20:37
    mongoKart
    mongoKart requested changes Jan 16, 2025
    View reviewed changes
    Copy link
    Collaborator

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Just Kerberos this time (in retrospect, maybe this should have been multiple PRs 😓 )

    another good job! some suggestions for clarity and small typos

    source/security/auth-mechanisms/kerberos.txt Outdated
    Comment on lines 77 to 78
    provide the password to the driver by using client configuration. You can also provide the
    path to a keytab file by storing the configuration in the ``java.security.auth.login.config`` system property.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    q: it says 'you can also provide...' what is this an alternative to?

    @mcmorisi mcmorisi requested a review from mongoKart January 17, 2025 15:55
    mongoKart
    mongoKart approved these changes Jan 17, 2025
    View reviewed changes
    Copy link
    Collaborator

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM w/ a couple small things for X.509. really nice work on lots of long pages!

    @mcmorisi mcmorisi merged commit 12625a2 into mongodb:standardization Jan 17, 2025
    5 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jamis jamis jamis approved these changes

    @mongoKart mongoKart mongoKart approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mcmorisi @jamis @mongoKart