-
Notifications
You must be signed in to change notification settings - Fork 29
DOCSP-45176: Run a command #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-45176: Run a command #130
Conversation
✅ Deploy Preview for docs-ruby ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small fix:
|
||
* - ``ok?`` | ||
- Returns ``true`` if the command succeeded, and ``false`` otherwise. If the ``ok?`` | ||
method returns ``false``The driver raises a ``Mongo::Error::OperationFailure`` . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
method returns ``false``The driver raises a ``Mongo::Error::OperationFailure`` . | |
method returns ``false``, the driver raises a ``Mongo::Error::OperationFailure`` . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
You can set a read preference for the command execution by passing a | ||
``ReadPreference`` instance as a parameter to ``command``, as | ||
shown in the following code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example given after this paragraph does not use a ReadPreference
instance, instead passing a hash of read preference options. Maybe the paragraph could be adjusted something like:
You can set a read preference for the command execution by passing a | |
``ReadPreference`` instance as a parameter to ``command``, as | |
shown in the following code: | |
You can set a read preference for the command execution by passing the | |
``:read`` option to the ``command`` method, as shown in the following code: |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45176
Staging Links
Self-Review Checklist