DOCSP-44627: Add retry information #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mayaraman19
approved these changes
Oct 24, 2024
source/fundamentals/transactions.txt
Outdated
| - | Runs the given callback, then commits or ends the transaction. When you | ||
| use this method to perform a transaction, the driver automatically | ||
| - | Runs the given callback, then commits or ends the transaction. If | ||
| the callback raises a transient transaction error, the driver retries |
There was a problem hiding this comment.
S: Maybe something to indicate the specific error type here, like
Suggested change
| the callback raises a transient transaction error, the driver retries | |
| the callback raises an error that includes a ``TRANSIENT_TRANSACTION_ERROR`` label, the driver retries |
abr-egn
reviewed
Oct 25, 2024
source/fundamentals/transactions.txt
Outdated
| use this method to perform a transaction, the driver automatically | ||
| handles any errors, so you can choose to omit error handling code. | ||
| - | Runs the given callback, then commits or ends the transaction. If | ||
| the callback raises an error with a ``TRANSIENT_TRANSACTION_ERROR`` |
There was a problem hiding this comment.
It will also retry if committing the transaction returns a transient error.
abr-egn
approved these changes
Oct 28, 2024
norareidy
added a commit
that referenced
this pull request
Oct 28, 2024
(cherry picked from commit 8f48bf7)
norareidy
added a commit
that referenced
this pull request
Oct 28, 2024
(cherry picked from commit 8f48bf7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44627
Staging - https://deploy-preview-132--docs-rust.netlify.app/fundamentals/transactions/#methods
Self-Review Checklist