-
Notifications
You must be signed in to change notification settings - Fork 21
DOCSP-44963: Data modeling in find usage examples #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-44963: Data modeling in find usage examples #137
Conversation
✅ Deploy Preview for docs-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a formatting suggestion
source/usage-examples/find.txt
Outdated
|
||
... | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: can we shorten these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restaurant_id is probably unnecessary, so I'll take that out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, this is a great way to contrast using the base Document
type vs. the serde
support 🙂
(cherry picked from commit 592712d)
(cherry picked from commit 592712d)
Pull Request Info
PR Reviewing Guidelines
Note: new structure was approved by the PM
JIRA -https://jira.mongodb.org/browse/DOCSP-44963
Staging -
https://deploy-preview-137--docs-rust.netlify.app/usage-examples/findOne/
https://deploy-preview-137--docs-rust.netlify.app/usage-examples/find/
Self-Review Checklist