Skip to content

DOCSP-44963: Data modeling in find usage examples #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 6, 2024

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Oct 30, 2024

Pull Request Info

PR Reviewing Guidelines

Note: new structure was approved by the PM
JIRA -https://jira.mongodb.org/browse/DOCSP-44963
Staging -
https://deploy-preview-137--docs-rust.netlify.app/usage-examples/findOne/
https://deploy-preview-137--docs-rust.netlify.app/usage-examples/find/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for docs-rust ready!

Name Link
🔨 Latest commit ea7d5b9
🔍 Latest deploy log https://app.netlify.com/sites/docs-rust/deploys/672b8adeb076f50008a6047f
😎 Deploy Preview https://deploy-preview-137--docs-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@norareidy norareidy changed the title DOCSP-44853: Data modeling in usage examples DOCSP-44963: Data modeling in find usage examples Oct 30, 2024
Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a formatting suggestion

Comment on lines 94 to 96

...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: can we shorten these

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restaurant_id is probably unnecessary, so I'll take that out

Copy link
Collaborator

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, this is a great way to contrast using the base Document type vs. the serde support 🙂

@norareidy norareidy merged commit 592712d into mongodb:master Nov 6, 2024
5 checks passed
@norareidy norareidy deleted the DOCSP-44853-update-usage-exs branch November 6, 2024 15:30
norareidy added a commit that referenced this pull request Nov 13, 2024
norareidy added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants