Skip to content

DOCSP-44967: Data modeling in update examples #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Nov 4, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44967
Staging -
https://deploy-preview-143--docs-rust.netlify.app/usage-examples/updateOne/
https://deploy-preview-143--docs-rust.netlify.app/usage-examples/updateMany/
https://deploy-preview-143--docs-rust.netlify.app/usage-examples/replace/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for docs-rust ready!

Name Link
🔨 Latest commit d80e15c
🔍 Latest deploy log https://app.netlify.com/sites/docs-rust/deploys/6734f40b3e5bbb0008d67054
😎 Deploy Preview https://deploy-preview-143--docs-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stephmarie17 stephmarie17 self-requested a review November 5, 2024 19:07
Copy link
Collaborator

@stephmarie17 stephmarie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question ✅

@isabelatkinson isabelatkinson self-requested a review November 7, 2024 17:06
Copy link
Collaborator

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one optional suggestion

``name`` field is ``"Landmark Coffee Shop"`` with a new document. MongoDB
replaces the first document that matches the query filter.
You can access the documents in the ``restaurants`` collection as instances
of the BSON data type or a custom data type. To specify which data type represents
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of the BSON data type or a custom data type. To specify which data type represents
of the ``Document`` type or a custom data type. To specify which data type represents

Ditto elsewhere. This more closely aligns with the code example, but feel free to leave as-is if the existing language is preferred.

@norareidy norareidy merged commit 734ed06 into mongodb:master Nov 13, 2024
5 checks passed
@norareidy norareidy deleted the DOCSP-44967-usage-ex-update-methods branch November 13, 2024 19:01
norareidy added a commit that referenced this pull request Nov 13, 2024
norareidy added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants