Skip to content

hasOne no longer compatible with latest Laravel #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WMeldon opened this issue Nov 1, 2013 · 6 comments
Closed

hasOne no longer compatible with latest Laravel #63

WMeldon opened this issue Nov 1, 2013 · 6 comments

Comments

@WMeldon
Copy link

WMeldon commented Nov 1, 2013

As of this change, errors are thrown due to method incompatibilities.

@jenssegers
Copy link
Contributor

Don't really know if I should change this now, or wait for the stable 4.1 release ...

@abishekrsrikaanth
Copy link

@jenssegers, you could have a seperate branch that points to the development version of Laravel 4.1, so that people working on Laravel 4.1 could use that branch to take advantage of all the new changes of Laravel 4.1. The master and the tags can still point to 4.0

@WMeldon
Copy link
Author

WMeldon commented Nov 4, 2013

A separate dev-type branch like @abishekrsrikaanth suggested that just maintains compatibility would be great. A lot of these things can just be fillers initially, I'd just rather not maintain my own fork to avoid simple errors.

@felixcheruiyot
Copy link

I agree with @abishekrsrikaanth and @WMeldon on this. This will be very helpful.

@jenssegers
Copy link
Contributor

The last commit on the develop branch updates some methods to their 4.1 version: 257b92f

Can you test this version?

@WMeldon
Copy link
Author

WMeldon commented Nov 4, 2013

Works like a charm. Thanks @jenssegers . I'll be back as soon as Taylor adds another method parameter to Eloquent :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants