use mongodb driver to check for dirtiness #1664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2018
Closed
|
Hello! Could you please take care for conflicting file or we can take a look? Thank you for your contribution! |
|
Hi there, This PR contains a breaking change and will be released within next version. Closing for now. Thanks. |
|
@divine I am glad this project became active. I'll send a PR within a day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check if a field is dirty we can simply use
fromPHP()function of the mongodb driver. Besides, we shouldn't use the SQL-specific logic ofIlluminate\Eloquent\Model::originalIsEquivalent()for mongodb. In sql, fields keep their schema data types and changing integer 1 to string '1' actually does nothing. However, in mongodb fields accept their types as they are inserted/updated. Therefore, if we change value of a field from(int)1to(string)'1'we actually must regard it as dirty.This change is backward incompatible. Don't know if anyone likes the current behaviour more.