Skip to content

[Updated PR#1491] Gets database name from DSN string #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 10, 2020

Conversation

divine
Copy link
Contributor

@divine divine commented Feb 9, 2020

This PR was recreated from #1491 with updated branch and resolved conflicting file.

--

This contains PR #1457
and in addition I've added an ability to use database name from DSN string, so it a developer passed DSN string its not necessary to pass database name.

hlorofos and others added 8 commits April 19, 2018 06:59

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Get database from dsn
@Smolevich Smolevich self-requested a review February 9, 2020 10:03
@Giacomo92
Copy link

Schermata 2020-02-09 alle 11 50 02

@Smolevich
Copy link
Contributor

@Giacomo92 i see this moment and case when $dsn be syntax incorrect will be happend
For example,
$dsn = 'mongodb://';
function return empty string

@Smolevich Smolevich merged commit 89fe91f into mongodb:master Feb 10, 2020
@divine divine deleted the pr_1491 branch February 10, 2020 21:50
@divine divine mentioned this pull request Feb 24, 2020
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
[Updated PR#1491] Gets database name from DSN string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants