[Updated PR#1145] Fix paginate in EmbedsMany #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smolevich
reviewed
Feb 11, 2020
Smolevich
previously approved these changes
Feb 11, 2020
divine
reviewed
Feb 12, 2020
Smolevich
approved these changes
Feb 13, 2020
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
[Updated PR#1145] Fix paginate in EmbedsMany
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was recreated from #1145
As describe here,
$items(a parameter ofLengthAwarePaginator) need to be an instance of Collection. I also converted theslice()operation with the collection's method and I have updated the docs.Co-Authored-By: @SamsamBabadi