Skip to content

[3.x] Fix refresh() on EmbedsOne #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2020
Merged

[3.x] Fix refresh() on EmbedsOne #1996

merged 2 commits into from
Mar 12, 2020

Conversation

stephandesouza
Copy link
Contributor

Fixes #1995

Model::refresh() throws TypeError exception when using EmbedOne

@codecov-io
Copy link

Codecov Report

Merging #1996 into master will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1996      +/-   ##
============================================
+ Coverage     86.75%   87.04%   +0.28%     
- Complexity      666      667       +1     
============================================
  Files            31       31              
  Lines          1518     1521       +3     
============================================
+ Hits           1317     1324       +7     
+ Misses          201      197       -4     
Impacted Files Coverage Δ Complexity Δ
src/Jenssegers/Mongodb/Relations/EmbedsOne.php 95.45% <100.00%> (+10.08%) 22.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279b18c...89667a5. Read the comment docs.

@stephandesouza stephandesouza changed the title Fix refresh() on EmbedsOne []Fix refresh() on EmbedsOne Mar 11, 2020
@stephandesouza stephandesouza changed the title []Fix refresh() on EmbedsOne [3.x] Fix refresh() on EmbedsOne Mar 11, 2020
@Smolevich Smolevich merged commit 98bc2f5 into mongodb:master Mar 12, 2020
@stephandesouza stephandesouza deleted the fix-embedsone-refresh branch March 12, 2020 16:50
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model can't be refreshed when using EmbedsOne
4 participants