Skip to content

Fix issue parsing millisecond-precision dates before 1970. #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Fix issue parsing millisecond-precision dates before 1970. #2028

merged 3 commits into from
Apr 23, 2020

Conversation

DFurnes
Copy link
Contributor

@DFurnes DFurnes commented Apr 22, 2020

This pull request adds some tests & a fix for an issue I ran into where pre-1970 dates with millisecond-precision could not be properly cast into a Carbon instance.

References #2026.
closes #2026

@DFurnes DFurnes marked this pull request as ready for review April 22, 2020 22:53
@DFurnes DFurnes changed the title Add tests for millisecond date bug. Fix issue parsing millisecond-precision dates before 1970. Apr 22, 2020
@Smolevich Smolevich self-requested a review April 23, 2020 06:13
@Smolevich
Copy link
Contributor

Thanks for contributing!

@Smolevich Smolevich merged commit 736415e into mongodb:master Apr 23, 2020
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
Fix issue parsing millisecond-precision dates before 1970.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading UTCDateTime from before 1970 results in an exception.
2 participants