Skip to content

Test with lowest dependencies in CI #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Test with lowest dependencies in CI #2663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
build:
runs-on: ${{ matrix.os }}
name: PHP v${{ matrix.php }} with MongoDB ${{ matrix.mongodb }}
name: PHP v${{ matrix.php }} with MongoDB ${{ matrix.mongodb }} ${{ matrix.mode }}
strategy:
matrix:
os:
Expand All @@ -23,6 +23,10 @@ jobs:
- '8.1'
- '8.2'
- '8.3'
include:
- php: '8.1'
mongodb: '5.0'
mode: 'low-deps'
Copy link
Member Author

@GromNaN GromNaN Nov 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alcaeus this modifies an existing matrix combination instead of creating an extra one. I think it's perfect.
https://github.com/mongodb/laravel-mongodb/actions/runs/6735955088/job/18310279364?pr=2663


steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -63,7 +67,7 @@ jobs:
restore-keys: ${{ matrix.os }}-composer-
- name: Install dependencies
run: |
composer install --no-interaction
composer update --no-interaction $([[ "${{ matrix.mode }}" == low-deps ]] && echo ' --prefer-lowest --prefer-stable')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit different than what we do in PHPLIB IIRC, where the CI parameter is just the args to inject (and defaults to an empty string).

I'm sure this works though so no objection. The approach in PHPLIB also doesn't change the build title, which you've achieved here.

- name: Run tests
run: |
./vendor/bin/phpunit --coverage-clover coverage.xml
Expand Down