PHPORM-209 Add query builder helper to set read preference #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Jan 13, 2025
| @@ -113,6 +114,8 @@ class Builder extends BaseBuilder | |||
| */ | |||
| public $hint; | |||
|
|
|||
| private ReadPreference $readPreference; | |||
There was a problem hiding this comment.
I don't get why other properties are public. Using private by default to not add the new property to the API for no reason.
jmikola
approved these changes
Jan 13, 2025
| * | ||
| * @return $this | ||
| */ | ||
| public function readPreference(string $mode, ?array $tagSets = null, ?array $options = null): static |
There was a problem hiding this comment.
Just want to confirm that you don't need the ability to clear a ReadPreference previously assigned to the builder.
There was a problem hiding this comment.
Most of the operations using the query builder cannot be unset.
For this config, it's still possible to overwrite with an other read preference.
|
|
||
| yield 'timeout' => [ | ||
| ['find' => [[], ['maxTimeMS' => 2345]]], | ||
| fn (Builder $builder) => $builder->timeout(2.3456), |
There was a problem hiding this comment.
Noted that this tests integer truncation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-209
Query\Builder::readPreference()to set the read preference option for find and aggregate.Checklist