Support adding schema validation #3397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
LGTM. I'll note that this uses the default settings for validationAction and validationLevel, which causes an error when attempting to insert or update an invalid document.
We could allow users to supply their own $validationLevel and $validationAction to customise this behaviour, but I'm fine with adding this in a separate step.
|
@alcaeus Oh no that seems like a pretty crucial step and arbitrary to add so will do |
paulinevos
force-pushed
the
72_schema-validation
branch
from
2885359 to
e388600
Compare
To support the '$jsonSchema' operation on collections
paulinevos
force-pushed
the
72_schema-validation
branch
from
e388600 to
aa74bf5
Compare
alcaeus
approved these changes
Jun 4, 2025
paulinevos
added a commit
to paulinevos/laravel-mongodb
that referenced
this pull request
Jun 4, 2025
This reverts commit 7a0f0bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the
'$jsonSchema'operation on collections.Closes PHPORM-72.
Checklist