Skip to content

Commit ba72b7c

Browse files
TheSonOfThompbruugeyspark33shaneeza
authored
Adam/react 18 migration fork (#1832)
* Adds Combobox tests (#1811) * Adds todo tests * Update Combobox.spec.tsx * lint * Update Combobox.spec.tsx * Update SearchResultsMenu.story.tsx (#1813) * [INTEGRATION LG-3296] Build Pipeline (#1812) * Adam/tsconfig (#1806) * lerna exec. extend build.tsconfig * updates internal tsconfig * rm old tsconfigs * rm legacy script * init config/package.json * updates paths * updates check:ts script * Update create-package.js * check:ts also builds dependents * Build tooling (#1807) * lerna exec. extend build.tsconfig * updates internal tsconfig * updates paths * Create update-package-json.ts * Update package.json * add tsc to package.json * adds turbo * Create turbo.yml * Update package.json * update ci * Update turbo.json * rm cycle * updates CI * Setup nx vs turbo benchmark job * Update benchmark.yml * rename lint script * rm yarn cache * Update turbo.json * update build dependencies * Adds baseline job * Updates configs & ci Update turbo.json Update turbo.json Update nx.json Update benchmark.yml restore build-storybook fixes dependencies Create sizeDiff.yml Update sizeDiff.yml Update sizeDiff.yml Update .npmpackagejsonlintrc.json rm lodash from icon-button rm bad references from palette story fix nx? * removes nx.json * Delete update-package-json.ts * Update Palette.story.tsx * Update Palette.story.tsx * Update .gitignore * rm build:turbo * fix story build error * fix split button & menu story imports * Adds federation icon (#1827) * Fix release script (#1828) * LG-3358, LG-3385 - Change Lottie dependency (#1826) * change lottie deps * changeset --------- Co-authored-by: brooke <[email protected]> * Updates icon for dark mode (#1825) * with changeset (#1824) * yarn update * rm resolution * fix basic TS * resolve RTG types * runs implicit-children codemod * lint * LG-3667: Updates disabled Radio label (#1831) * with changeset * rm console * use label prop to style * fix formfooter error (#1833) * fixes tooltip TS issues * fix side-nav TS errors (#1834) * fixes bug introduced * fix table ts (#1835) * revert changes to isComponentGlyph (#1836) * fix sc bugs * last sc fix * prettier * Update examples.spec.tsx * heap? * runs lint too * fix combobox tsc --------- Co-authored-by: Brooke Scarlett Yalof <[email protected]> Co-authored-by: Sean Park <[email protected]> Co-authored-by: Shaneeza <[email protected]>
1 parent 0e1b059 commit ba72b7c

File tree

232 files changed

+6251
-9413
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

232 files changed

+6251
-9413
lines changed

.changeset/gentle-shoes-join.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/text-input': patch
3+
---
4+
5+
Updates valid state icon in dark mode to match Figma spec

.changeset/little-comics-deny.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/loading-indicator': major
3+
---
4+
5+
Changing Lottie dependency from @lottie-files/react-lottie-player to react-lottie-player

.changeset/little-spoons-doubt.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/segmented-control': minor
3+
---
4+
5+
Label prop now accepts type `React.ReactNode` instead of `string`

.changeset/spicy-hairs-fly.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/radio-group': patch
3+
---
4+
5+
Updates label color when disabled to match Figma spec

.changeset/three-lobsters-cough.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/icon': minor
3+
---
4+
5+
Adds 'Federation' icon to glyph set
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Node.js CI
1+
name: Pull Request CI
22

33
on:
44
pull_request:
@@ -9,80 +9,9 @@ concurrency:
99
cancel-in-progress: true
1010

1111
jobs:
12-
install:
13-
name: Install node modules
14-
runs-on: ubuntu-latest
15-
steps:
16-
- name: Checkout Repo
17-
uses: actions/checkout@v2
18-
19-
- name: Use Node.js 16
20-
uses: actions/setup-node@v3
21-
with:
22-
node-version: '16'
23-
cache: yarn
24-
cache-dependency-path: 'yarn.lock'
25-
26-
- name: Install
27-
run: yarn install --frozen-lockfile --prefer-offline
28-
29-
outputs:
30-
yarn-cache-dir: ${{ steps.get-yarn-cache-dir.outputs.dir }}
31-
32-
lints:
12+
lint:
3313
name: Check lints
3414
runs-on: ubuntu-latest
35-
needs: install
36-
steps:
37-
- uses: actions/checkout@v2
38-
39-
- name: Use Node.js 16
40-
uses: actions/setup-node@v3
41-
with:
42-
node-version: '16'
43-
cache: yarn
44-
cache-dependency-path: 'yarn.lock'
45-
46-
- run: yarn install --frozen-lockfile --prefer-offline
47-
48-
- name: prettier
49-
run: yarn check:prettier
50-
51-
- name: eslint
52-
run: yarn check:eslint --format junit -o reports/junit/js-lint-results.xml
53-
54-
types:
55-
name: Check types
56-
runs-on: ubuntu-latest
57-
needs: install
58-
steps:
59-
- uses: actions/checkout@v2
60-
61-
- name: Use Node.js 16
62-
uses: actions/setup-node@v3
63-
with:
64-
node-version: '16'
65-
cache: yarn
66-
cache-dependency-path: 'yarn.lock'
67-
68-
- run: yarn install --frozen-lockfile --prefer-offline
69-
70-
- uses: actions/cache/restore@v3
71-
name: Restore TS cache
72-
id: ts-cache
73-
with:
74-
path: |
75-
**/dist/**/*.ts
76-
!**/node_modules
77-
key: ${{ runner.os }}-ts-cache-${{ hashFiles('**/tsconfig.js', '**/package.tsconfig.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}
78-
79-
- name: types
80-
run: yarn check:ts
81-
82-
deps:
83-
name: Check dependency list
84-
runs-on: ubuntu-latest
85-
needs: install
8615
steps:
8716
- uses: actions/checkout@v2
8817

@@ -95,16 +24,15 @@ jobs:
9524

9625
- run: yarn install --frozen-lockfile --prefer-offline
9726

98-
- name: deps
99-
run: yarn check:deps
27+
- name: lint
28+
run: yarn lint
10029

101-
- name: package.json versions
102-
run: yarn check:package-json
30+
outputs:
31+
yarn-cache-dir: ${{ steps.get-yarn-cache-dir.outputs.dir }}
10332

10433
build:
10534
name: Build packages
10635
runs-on: ubuntu-latest
107-
needs: [install, lints]
10836
steps:
10937
- uses: actions/checkout@v2
11038

@@ -132,44 +60,12 @@ jobs:
13260

13361
- name: build
13462
if: ${{ steps.build-cache.outputs.cache-hit != 'true' }}
135-
run: yarn build:packages
136-
137-
build-ts:
138-
name: Build TypeScript
139-
runs-on: ubuntu-latest
140-
needs: [install, lints]
141-
steps:
142-
- uses: actions/checkout@v2
143-
144-
- uses: actions/cache@v3
145-
name: Check for ts cache
146-
id: ts-cache
147-
with:
148-
path: |
149-
**/dist/**/*.ts
150-
!**/node_modules
151-
key: ${{ runner.os }}-ts-cache-${{ hashFiles('**/tsconfig.js', '**/package.tsconfig.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}
152-
153-
- name: Use Node.js 16
154-
if: ${{ steps.ts-cache.outputs.cache-hit != 'true' }}
155-
uses: actions/setup-node@v3
156-
with:
157-
node-version: '16'
158-
cache: yarn
159-
cache-dependency-path: 'yarn.lock'
160-
161-
- name: Install
162-
if: ${{ steps.ts-cache.outputs.cache-hit != 'true' }}
163-
run: yarn install --frozen-lockfile --prefer-offline
164-
165-
- name: build-ts
166-
if: ${{ steps.ts-cache.outputs.cache-hit != 'true' }}
167-
run: yarn build:ts
63+
run: yarn build
16864

16965
chromatic:
17066
name: Chromatic
17167
runs-on: ubuntu-latest
172-
needs: [install, build]
68+
needs: [build]
17369
steps:
17470
- name: Checkout
17571
uses: actions/checkout@v2
@@ -205,7 +101,7 @@ jobs:
205101
tests:
206102
name: Run tests
207103
runs-on: ubuntu-latest
208-
needs: [install, build]
104+
needs: [build]
209105
steps:
210106
- uses: actions/checkout@v2
211107

@@ -235,7 +131,7 @@ jobs:
235131
tests-ssr:
236132
name: Run tests with artificial server rendering
237133
runs-on: ubuntu-latest
238-
needs: [install, build]
134+
needs: [build]
239135
steps:
240136
- uses: actions/checkout@v2
241137

@@ -262,10 +158,10 @@ jobs:
262158
env:
263159
JEST_JUNIT_OUTPUT: 'reports/junit/js-test-ssr-results.xml'
264160

265-
checkBuilds:
266-
name: Verify builds
161+
validate-builds:
162+
name: Validate builds & dependencies
267163
runs-on: ubuntu-latest
268-
needs: [install, build, build-ts]
164+
needs: [build]
269165
steps:
270166
- uses: actions/checkout@v2
271167

@@ -296,36 +192,5 @@ jobs:
296192
!**/node_modules
297193
key: ${{ runner.os }}-ts-cache-${{ hashFiles('**/tsconfig.js', '**/package.tsconfig.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}
298194

299-
- name: check builds
300-
run: yarn check:builds
301-
302-
sizeDiff:
303-
name: Check file size
304-
runs-on: ubuntu-latest
305-
needs: install
306-
steps:
307-
- uses: actions/checkout@v2
308-
309-
- name: Use Node.js 16
310-
uses: actions/setup-node@v3
311-
with:
312-
node-version: '16'
313-
cache: yarn
314-
cache-dependency-path: 'yarn.lock'
315-
316-
- run: yarn install --frozen-lockfile --prefer-offline
317-
318-
- uses: actions/cache/restore@v3
319-
name: Restore build cache
320-
id: build-cache
321-
with:
322-
path: |
323-
**/dist
324-
!**/node_modules
325-
key: ${{ runner.os }}-build-cache-${{ hashFiles('**/rollup.config.js', '**/babel.config.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}
326-
327-
- uses: preactjs/compressed-size-action@v2
328-
with:
329-
repo-token: ${{ secrets.GITHUB_TOKEN }}
330-
clean-script: 'clean:builds && clean:modules'
331-
build-script: 'build:packages'
195+
- name: validate
196+
run: yarn validate

.github/workflows/release.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ jobs:
2424
run: yarn
2525

2626
- name: Build packages
27-
run: yarn build:packages
27+
run: yarn build
2828

2929
- name: Build typescript
30-
run: yarn build:ts
30+
run: yarn tsc
3131

3232
- name: Build TSDoc
33-
run: yarn docs:tsdoc
33+
run: yarn build:docs
3434

3535
- name: Establish Chromatic baseline
3636
uses: chromaui/action@v1

.github/workflows/sizeDiff.yml

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
name: File Size
2+
3+
on:
4+
pull_request:
5+
types: [opened, synchronize, reopened]
6+
7+
jobs:
8+
sizeDiff:
9+
name: Check file size
10+
runs-on: ubuntu-latest
11+
steps:
12+
- uses: actions/checkout@v2
13+
14+
- name: Use Node.js 16
15+
uses: actions/setup-node@v3
16+
with:
17+
node-version: '16'
18+
cache: yarn
19+
cache-dependency-path: 'yarn.lock'
20+
21+
- run: yarn install --frozen-lockfile --prefer-offline
22+
23+
- uses: actions/cache/restore@v3
24+
name: Restore build cache
25+
id: build-cache
26+
with:
27+
path: |
28+
**/dist
29+
!**/node_modules
30+
key: ${{ runner.os }}-build-cache-${{ hashFiles('**/rollup.config.js', '**/babel.config.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}
31+
32+
- uses: preactjs/compressed-size-action@v2
33+
with:
34+
repo-token: ${{ secrets.GITHUB_TOKEN }}
35+
clean-script: 'clean'
36+
build-script: 'build'

.github/workflows/test-dispatch.yml

-20
This file was deleted.

.gitignore

+2-1
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,5 @@ packages/**/stories.js*
4747
# Storybook/Chromatic logs
4848
build-storybook.log
4949

50-
.turbo
50+
.turbo
51+
scripts/tmp.*.ts

.npmpackagejsonlintrc.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
{
77
"patterns": ["./packages/code/package.json"],
88
"rules": {
9-
"prefer-caret-version-dependencies": "warning"
9+
"prefer-caret-version-dependencies": "off"
1010
}
1111
}
1212
]

STYLEGUIDE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export const someConstant = {
5555
optionTwo = 'option 2',
5656
} as const;
5757

58-
export type someConstant = typeof someConstant[keyof typeof someConstant];
58+
export type someConstant = (typeof someConstant)[keyof typeof someConstant];
5959
```
6060

6161
#### Avoid

0 commit comments

Comments
 (0)