LG-3667: Updates disabled Radio label #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 762df55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shaneeza
reviewed
Jul 7, 2023
| @@ -71,6 +74,7 @@ function Radio({ | |||
| className={cx( | |||
| labelBaseStyle, | |||
| { | |||
| [labelDisabledStyle[theme]]: disabled, | |||
There was a problem hiding this comment.
Can you use the disabled prop instead of adding CSS? It looks like the colors are the same.
|
Size Change: +6 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
shaneeza
approved these changes
Jul 10, 2023
bruugey
added a commit
that referenced
this pull request
Jul 11, 2023
* Adds Combobox tests (#1811) * Adds todo tests * Update Combobox.spec.tsx * lint * Update Combobox.spec.tsx * Update SearchResultsMenu.story.tsx (#1813) * [INTEGRATION LG-3296] Build Pipeline (#1812) * Adam/tsconfig (#1806) * lerna exec. extend build.tsconfig * updates internal tsconfig * rm old tsconfigs * rm legacy script * init config/package.json * updates paths * updates check:ts script * Update create-package.js * check:ts also builds dependents * Build tooling (#1807) * lerna exec. extend build.tsconfig * updates internal tsconfig * updates paths * Create update-package-json.ts * Update package.json * add tsc to package.json * adds turbo * Create turbo.yml * Update package.json * update ci * Update turbo.json * rm cycle * updates CI * Setup nx vs turbo benchmark job * Update benchmark.yml * rename lint script * rm yarn cache * Update turbo.json * update build dependencies * Adds baseline job * Updates configs & ci Update turbo.json Update turbo.json Update nx.json Update benchmark.yml restore build-storybook fixes dependencies Create sizeDiff.yml Update sizeDiff.yml Update sizeDiff.yml Update .npmpackagejsonlintrc.json rm lodash from icon-button rm bad references from palette story fix nx? * removes nx.json * Delete update-package-json.ts * Update Palette.story.tsx * Update Palette.story.tsx * Update .gitignore * rm build:turbo * fix story build error * fix split button & menu story imports * Adds federation icon (#1827) * Fix release script (#1828) * LG-3358, LG-3385 - Change Lottie dependency (#1826) * change lottie deps * changeset --------- Co-authored-by: brooke <[email protected]> * Updates icon for dark mode (#1825) * with changeset (#1824) * yarn update * rm resolution * fix basic TS * resolve RTG types * runs implicit-children codemod * lint * LG-3667: Updates disabled Radio label (#1831) * with changeset * rm console * use label prop to style * fix formfooter error (#1833) * fixes tooltip TS issues * fix side-nav TS errors (#1834) * fixes bug introduced * fix table ts (#1835) * revert changes to isComponentGlyph (#1836) * fix sc bugs * last sc fix * prettier * Update examples.spec.tsx * heap? * runs lint too * fix combobox tsc --------- Co-authored-by: Brooke Scarlett Yalof <[email protected]> Co-authored-by: Sean Park <[email protected]> Co-authored-by: Shaneeza <[email protected]>
bruugey
added a commit
that referenced
this pull request
Aug 9, 2023
* with changeset * rm console * use label prop to style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-3667
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes