PD-1669 Add size variants to text input #1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +339 B (0%) Total Size: 394 kB
ℹ️ View Unchanged
|
TheSonOfThomp
requested changes
Dec 3, 2021
| @@ -107,6 +117,8 @@ interface TextInputProps extends HTMLElementProps<'input', HTMLInputElement> { | |||
| handleValidation?: (value: string) => void; | |||
|
|
|||
| ['aria-labelledby']?: string; | |||
|
|
|||
| sizeVariant?: SizeVariantType; | |||
There was a problem hiding this comment.
I think we should just call this prop size to keep in line with other components
There was a problem hiding this comment.
I tried to use size but it looks like since we're using the HTMLInputElement interface, on line 52, that already has a property of size with a type of number so I was getting a TS error. To avoid that I changed it to sizeVariant.
shaneeza
changed the title
Comment on lines
+225
to
+239
| describe('when the "sizeVariant" is "large"', () => { | ||
| test('check if font-size is 18px', () => { | ||
| const { label } = renderTextInput({ | ||
| value: validEmail, | ||
| sizeVariant: SizeVariant.Large, | ||
| optional: true, | ||
| ...defaultProps, | ||
| }); | ||
|
|
||
| expect(label).toHaveStyle({ | ||
| fontSize: '18px', | ||
| }); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This works for now, but this type of test is better suited to something like Chromatic or Percy
There was a problem hiding this comment.
We could even consider using this package https://www.npmjs.com/package/jest-image-snapshot
TheSonOfThomp
approved these changes
Dec 15, 2021
* Update package.json * Create shiny-sloths-joke.md
bruugey
pushed a commit
that referenced
this pull request
Aug 9, 2023
* update text input to include size variants * prettier fixes * updated website component * update readme again * prettier fixes * added input text size * changeset update * changed size default to default * add padding * remove medium size, add baseFontSize * naming updates, prettier fixes * update error font size * PD-1694 Upgrade `lib` dep in expandable card (#1073) * Update package.json * Create shiny-sloths-joke.md * removed submodules and updated node version in readme (#1075) Co-authored-by: Adam Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: PD-1669
🛠 Types of changes
✅ Checklist
yarn changesetand documented my changes🧪 How to test changes
💬 Further comments