LG-4511: add badgeProps to BasicEmptyState #2497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cc62ffe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stephl3
force-pushed
the
steph/oc-empty-state-badge
branch
from
386e6dc to
4e1c639
Compare
|
Size Change: +192 B (+0.01%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/oc-empty-state-badge
branch
from
4e1c639 to
a5b6865
Compare
tsck
approved these changes
Oct 8, 2024
packages/empty-state/src/BasicEmptyState/BasicEmptyState.styles.ts
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Oct 8, 2024
| @@ -33,6 +33,7 @@ import { BasicEmptyState } from '@leafygreen-ui/empty-state'; | |||
| title="No Results Found" | |||
| description="Try adjusting your filters or search terms" | |||
| graphic={<SvgOrImgComponent />} | |||
| badgeProps={{ variant: 'blue', children: 'Optional' }} | |||
There was a problem hiding this comment.
I'm curious—we allow components for the other props, like primaryButton, so why did we make this an object?
There was a problem hiding this comment.
I was continuing the pattern we're using elsewhere, such as FormFooter and ConfirmationModal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
badgePropstoBasicEmptyStatecomponent🎟 Jira ticket: LG-4511
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes🧪 How to test changes
BasicEmptyStatestorybook examples