feat(NODE-5420)!: remove JS bindings from libmongocrypt

.evergreen/config.yml

@@ -523,11 +523,6 @@ tasks:
     - func: "fetch source"
     - func: "build and publish node"
 
-- name: build-and-test-node-no-peer-dependencies
-  commands:
-    - func: "fetch source"
-    - func: "build and test node no peer dependencies"
-    - func: "attach node xunit results"
 
 # Note: keep this disabled unless you want master to force-push
 - name: build-and-test-node-force-publish
@@ -1004,7 +999,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - build-and-publish-node
   - test-java
   - name: publish-packages
@@ -1018,7 +1012,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan-mac
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - build-and-publish-node
   - build-and-test-csharp
   - test-python
@@ -1064,7 +1057,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-csharp
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - build-and-publish-node
   - test-java
   - windows-upload-check
@@ -1091,7 +1083,6 @@ buildvariants:
   - build-and-test-and-upload
   - build-and-test-shared-bson
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1109,7 +1100,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1127,7 +1117,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - name: publish-packages
     distros:
     - rhel70-small
@@ -1143,7 +1132,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1160,7 +1148,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1178,7 +1165,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1209,7 +1195,7 @@ buildvariants:
   - build-and-test-and-upload
   - build-and-test-shared-bson
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
+  - test-python
   - test-java
   - name: publish-packages
     distros:
@@ -1239,8 +1225,6 @@ buildvariants:
   - build-and-test-and-upload
   - build-and-test-shared-bson
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
-  - test-python
   - test-java
   - name: publish-packages
     distros:
@@ -1258,7 +1242,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1276,7 +1259,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1294,7 +1276,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - build-and-publish-node
   - test-java
   - name: publish-packages
@@ -1313,7 +1294,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - build-and-test-csharp
   - test-java
   - name: publish-packages
@@ -1342,7 +1322,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1361,7 +1340,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - build-and-test-csharp
   - test-java
   - upload-java
@@ -1379,7 +1357,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1398,7 +1375,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   # see https://jira.mongodb.org/browse/MONGOCRYPT-515
   #- build-and-test-csharp
   - test-java
@@ -1418,7 +1394,6 @@ buildvariants:
   - build-and-test-shared-bson
   - build-and-test-asan
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - test-java
   - name: publish-packages
     distros:
@@ -1448,7 +1423,6 @@ buildvariants:
   tasks:
   - build-and-test-and-upload
   - build-and-test-node
-  - build-and-test-node-no-peer-dependencies
   - build-and-publish-node
   - test-python
   - test-java

bindings/node/.eslintrc.json

@@ -2,8 +2,11 @@
   "root": true,
   "extends": [
     "eslint:recommended",
-    "plugin:prettier/recommended"
+    "plugin:prettier/recommended",
+    "plugin:@typescript-eslint/eslint-recommended",
+    "plugin:@typescript-eslint/recommended"
   ],
+  "ignorePatterns": "lib/**/*",
   "env": {
     "node": true,
     "mocha": true,
@@ -13,6 +16,7 @@
     "ecmaVersion": 2019
   },
   "plugins": [
+    "@typescript-eslint",
     "prettier"
   ],
   "rules": {
@@ -34,8 +38,17 @@
     "prettier/prettier": "error",
     "no-console": "error",
     "valid-typeof": "error",
-    "eqeqeq": ["error", "always", {"null": "ignore"}],
-    "strict": ["error", "global"],
+    "eqeqeq": [
+      "error",
+      "always",
+      {
+        "null": "ignore"
+      }
+    ],
+    "strict": [
+      "error",
+      "global"
+    ],
     "no-restricted-syntax": [
       "error",
       {
@@ -55,17 +68,5 @@
         "message": "Do not strictly check typeof undefined (NOTE: currently this rule only detects the usage of 'undefined' string literal so this could be a misfire)"
       }
     ]
-  },
-  "overrides": [
-    {
-      // Settings for javascript test files
-      "files": [
-        "test/**/*.js"
-      ],
-      "rules": {
-        "no-console": "off",
-        "no-restricted-syntax": "off"
-      }
-    }
-  ]
+  }
 }

bindings/node/.gitignore

@@ -20,3 +20,7 @@ deps
 *.tgz
 
 xunit.xml
+
+# built typescript
+lib
+prebuilds

bindings/node/.mocharc.json

@@ -1,8 +1,13 @@
 {
   "$schema": "https://raw.githubusercontent.com/SchemaStore/schemastore/master/src/schemas/json/mocharc.json",
   "require": [
+    "source-map-support/register",
+    "ts-node/register",
     "test/tools/chai-addons.js"
   ],
+  "extension": [
+    "ts"
+  ],
   "recursive": true,
   "failZero": true,
   "reporter": "test/tools/mongodb_reporter.js",

bindings/node/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [6.0.0-alpha.0](https://github.com/mongodb/libmongocrypt/compare/node-v2.9.0...node-v6.0.0-alpha.0) (2023-07-13)
+
 ## [2.9.0](https://github.com/mongodb/libmongocrypt/compare/node-v2.8.0...node-v2.9.0) (2023-07-12)
 
 ## [2.8.0](https://github.com/mongodb/libmongocrypt/compare/node-v2.8.0-alpha.0...node-v2.8.0) (2023-05-11)

bindings/node/src/mongocrypt.cc → bindings/node/addon/mongocrypt.cc

@@ -1,7 +1,7 @@
 #include "mongocrypt.h"
 #include <cassert>
 
-#ifdef _MSC_VER 
+#ifdef _MSC_VER
 #define strncasecmp _strnicmp
 #define strcasecmp _stricmp
 #endif

bindings/node/binding.gyp

@@ -18,7 +18,7 @@
         ]
     },
     'sources': [
-      'src/mongocrypt.cc'
+      'addon/mongocrypt.cc'
     ],
     'xcode_settings': {
       'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',

bindings/node/etc/prepare.js

@@ -0,0 +1,12 @@
+#! /usr/bin/env node
+var cp = require('child_process');
+var fs = require('fs');
+var os = require('os');
+
+if (fs.existsSync('src')) {
+  cp.spawn('npm', ['run', 'build:ts'], { stdio: 'inherit', shell: os.platform() === 'win32' });
+} else {
+  if (!fs.existsSync('lib')) {
+    console.warn('MongoDB: No compiled javascript present, the driver is not installed correctly.');
+  }
+}