Skip to content

evg: remove config_generator.etc.utils.Task #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

eramongodb
Copy link
Collaborator

@eramongodb eramongodb commented Oct 11, 2024

Long overdue followup to #1201. Following evergreen-ci/shrub.py#37, config_generator.etc.utils.Task is no longer necessary as all task fields required by the C Driver EVG config (i.e. run_on) are now supported by shrub.v3.evg_task.EvgTask.

Updates shrub.py to 3.3.0 (s/3.1.3/3.3.0/ -> poetry lock) and refactors the config generator scripts accordingly.

@eramongodb eramongodb requested a review from kevinAlbs October 11, 2024 18:39
@eramongodb eramongodb self-assigned this Oct 11, 2024
@eramongodb
Copy link
Collaborator Author

Also simplify our custom YAML dumper class implementation following evergreen-ci/shrub.py#36.

Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see workarounds are no longer needed. LGTM.

@eramongodb eramongodb merged commit 1e754dc into mongodb:master Oct 11, 2024
42 of 44 checks passed
@eramongodb eramongodb deleted the cdriver-shrub branch October 11, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants