CDRIVER-5969 return NULL result if no writes indicated #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdb-ad
approved these changes
Apr 15, 2025
kevinAlbs
added a commit
to kevinAlbs/mongo-c-driver
that referenced
this pull request
Apr 15, 2025
kevinAlbs
added a commit
that referenced
this pull request
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Return NULL
mongoc_bulkwrite_result_tif no server reply indicated writes were attempted.Verified by this patch build.
Background & Motivation
Quoting Bulk Write spec:
The C driver incorrectly assumed the absence of errors indicated a successful write. But a client-side error could be returned before any attempts to send writes.
This PR includes an additional check to ensure an
ok:1server reply was received and parsed to indicate the server attempted writes.