VS-118: Create Analyzer EG pipeline #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
requested changes
May 9, 2024
evergreen/evergreen.yml
Outdated
| OS=${OS} \ | ||
| ${PROJECT_DIRECTORY}/evergreen/install-dependencies.sh | ||
|
|
||
| prepare-resources: |
| { | ||
| var driverVersion = Environment.GetEnvironmentVariable("DRIVER_VERSION"); | ||
|
|
||
| if (driverVersion != null) |
There was a problem hiding this comment.
IMHO: it would be better just to expect of Environment variable to be set. Because otherwise it could hide missed variable, by using defaults.
There was a problem hiding this comment.
We need those presets for testing in IDE.
But good point, maybe we can think of some other trick.
There was a problem hiding this comment.
In Rider there is a way to specify Environment vars for unit tests. I suppose VS could have something similar.
sanych-sun
requested changes
May 9, 2024
| if [ -z "$PACKAGE_VERSION" ] | ||
| then | ||
| PACKAGE_VERSION=$(git describe --tags) | ||
| echo Calculated PACKAGE_VERSION value: "$PACKAGE_VERSION" |
There was a problem hiding this comment.
In Driver's CI we agreed not to calculate PACKAGE_VERSION for package_push script to avoid accidental pushing incorrect version to nuget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.