Skip to content

CSHARP-4765: CI script to generate Driver's dev-package #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

sanych-sun
Copy link
Member

@sanych-sun sanych-sun commented Aug 29, 2023

@sanych-sun sanych-sun requested a review from a team as a code owner August 29, 2023 19:00
@sanych-sun sanych-sun requested review from adelinowona and removed request for a team August 29, 2023 19:00
export UPLOAD_BUCKET="${project}"
# revert this change before merging into master
# export UPLOAD_BUCKET="${project}"
export UPLOAD_BUCKET="dot-net-driver"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added to let me test the CI, otherwise I've got access denied from s3. Need to be reverted before the merge.

@sanych-sun sanych-sun requested review from JamesKovacs and BorisDog and removed request for adelinowona and JamesKovacs August 29, 2023 19:03
@sanych-sun sanych-sun force-pushed the evergreen-experiments branch from 2a52d8a to 4ae4f32 Compare August 29, 2023 22:21
@BorisDog
Copy link
Contributor

@sanych-sun can you please add a EG link demonstrating this new CI?

PACKAGE_ID: "mongocsharpdriver"
- func: packages-push
vars:
PACKAGES_SOURCE: "https://nuget.pkg.github.com/sanych-sun/index.json"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with MongoDB namespace before merge into master

@rstam rstam self-requested a review September 1, 2023 20:56
Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review every last line, but the changes in general seem solid.

LGMT

@sanych-sun sanych-sun requested a review from BorisDog September 1, 2023 23:41
Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanych-sun sanych-sun force-pushed the evergreen-experiments branch 3 times, most recently from 0edf854 to d08c5c7 Compare September 6, 2023 23:40
@sanych-sun sanych-sun force-pushed the evergreen-experiments branch from 35fe117 to 4fae118 Compare September 16, 2023 00:30
@sanych-sun sanych-sun force-pushed the evergreen-experiments branch from 1441592 to a04a61d Compare October 4, 2023 19:52
@sanych-sun sanych-sun force-pushed the evergreen-experiments branch from a04a61d to 7c99b54 Compare October 4, 2023 20:04
@sanych-sun sanych-sun merged commit cb90413 into master Oct 4, 2023
@sanych-sun sanych-sun deleted the evergreen-experiments branch October 4, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants