-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-3985: Support multiple SerializerRegistries #1592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
papafe
wants to merge
51
commits into
mongodb:main
Choose a base branch
from
papafe:csharp3985
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 16 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
5a93d57
First test
papafe bc33071
Revert "First test"
papafe 5e94e62
Added manager
papafe a317994
Delegating all the methods to the BsonSerializationManager
papafe 0e2f7b9
Added interface
papafe a051d18
Small fix
papafe bb60887
Rename
papafe 56a9b7e
Added internal interface
papafe 3f634d5
Improvements
papafe 550eb97
Initial use of domain
papafe d2e1746
Fix
papafe 8b14426
Added comments
papafe 3dadb07
Test with multiple interfaces
papafe cf05d41
Improved interfaces
papafe 35f461a
Fix to interface
papafe 7c2beb3
Small renaming
papafe 3ad811e
Added comments
papafe 0ae768c
Finished comments in the Bson lib
papafe 01330fd
Corrected conventions
papafe 7bec37f
Correction
papafe bb395b0
Corrected convention tests
papafe d7756c6
Removed multiple interfaces plus more fixes
papafe 70f351b
More improvements
papafe cc40c72
Small fixes
papafe 04d45fa
Small fixes
papafe 8305dc1
improvements
papafe 402a889
Small fix
papafe 6d2faf9
Various fixes
papafe 5ac0c06
First test passing
papafe 7628f31
Small fixes
papafe 3f5a047
Some saving
papafe 9ccfe7a
Naming correction
papafe d3973e1
Added test and removed comment
papafe a587d6d
Improved tests
papafe 856cfb8
Improved deserialization to work as serialization
papafe 2cc6a8d
Trying to fix class map
papafe 5742541
Fixed class
papafe d6d9ddc
Various corrections
papafe 3b27b43
Moved class map to another file
papafe 98682bb
Removed comments
papafe dc33112
Passing domain in serializer registry
papafe a45b027
Small improvements
papafe 3f9c37c
Small corrections
papafe f0487d3
Renamin to serialization domain
papafe 2ed6fb6
Small naming correction
papafe 0074837
Fixed tests
papafe 9011589
removed comment
papafe 8b15445
Added convention registry
papafe 2157ae8
Some improvements
papafe ab7c5de
Removed domain from translation context
papafe e683791
Made something internal
papafe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably standardize on
Domain
orSerializationDomain
.SerializationDomain
is more accurate, but longer...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, at the moment it's a little bit here and there. I think serialization domain is a better name, even if longer.