-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-5529: Optimize grouping.First().X to not retrieve the entire $$ROOT #1653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rstam
wants to merge
2
commits into
mongodb:main
Choose a base branch
from
rstam:csharp5529
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
tests/MongoDB.Driver.Tests/Linq/Linq3Implementation/Jira/CSharp5529Tests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using MongoDB.Driver.TestHelpers; | ||
| using FluentAssertions; | ||
| using Xunit; | ||
|
|
||
| namespace MongoDB.Driver.Tests.Linq.Linq3Implementation.Jira; | ||
|
|
||
| public class CSharp5529Tests : LinqIntegrationTest<CSharp5529Tests.ClassFixture> | ||
| { | ||
| public CSharp5529Tests(ClassFixture fixture) | ||
| : base(fixture) | ||
| { | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(1, 1, """{ $group: { _id : 1, __agg0 : { $first : "$X" } } }""", 1)] | ||
| [InlineData(1, 2, """{ $group: { _id : 1, __agg0 : { $last : "$X" } } }""", 2)] | ||
| [InlineData(2, 1, """{ $group: { _id : 1, __agg0 : { $first : "$D.Y" } } }""", 11)] | ||
| [InlineData(2, 2, """{ $group: { _id : 1, __agg0 : { $last : "$D.Y" } } }""", 22)] | ||
| [InlineData(3, 1, """{ $group: { _id : 1, __agg0 : { $first : "$D.E.Z" } } }""", 111)] | ||
| [InlineData(3, 2, """{ $group: { _id : 1, __agg0 : { $last : "$D.E.Z" } } }""", 222)] | ||
| public void First_or_Last_optimization_should_work(int level, int firstOrLast, string expectedGroupStage, int expectedResult) | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = (level, firstOrLast) switch | ||
| { | ||
| (1, 1) => collection.Aggregate().Group(x => 1, g => g.First().X), | ||
| (1, 2) => collection.Aggregate().Group(x => 1, g => g.Last().X), | ||
| (2, 1) => collection.Aggregate().Group(x => 1, g => g.First().D.Y), | ||
| (2, 2) => collection.Aggregate().Group(x => 1, g => g.Last().D.Y), | ||
| (3, 1) => collection.Aggregate().Group(x => 1, g => g.First().D.E.Z), | ||
| (3, 2) => collection.Aggregate().Group(x => 1, g => g.Last().D.E.Z), | ||
| _ => throw new ArgumentException() | ||
| }; | ||
|
|
||
| var stages = Translate(collection,queryable); | ||
| AssertStages( | ||
| stages, | ||
| expectedGroupStage, | ||
| """{ $project : { _v : "$__agg0", _id : 0 } }"""); | ||
|
|
||
| var result = queryable.Single(); | ||
| result.Should().Be(expectedResult); | ||
| } | ||
| public class C | ||
| { | ||
| public int Id { get; set; } | ||
| public int X { get; set; } | ||
|
|
||
| public D D { get; set; } | ||
| } | ||
|
|
||
| public class D | ||
| { | ||
| public E E { get; set; } | ||
| public int Y { get; set; } | ||
| } | ||
|
|
||
| public class E | ||
| { | ||
| public int Z { get; set; } | ||
| } | ||
|
|
||
| public sealed class ClassFixture : MongoCollectionFixture<C> | ||
| { | ||
| protected override IEnumerable<C> InitialData => | ||
| [ | ||
| new C { Id = 1, X = 1, D = new D { E = new E { Z = 111 }, Y = 11 } }, | ||
| new C { Id = 2, X = 2, D = new D { E = new E { Z = 222 }, Y = 22 } }, | ||
| ]; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename it to
IsConstantEqualsToor make it return the constant's value instead:public static bool IsConstant(this AstExpression expression, out BsonValue value)