Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSHARP-5552: Add support for $convert in LINQ #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSHARP-5552: Add support for $convert in LINQ #1659
Changes from 65 commits
b11abcb
e51d733
7484967
d604e2a
e46ebc6
9ff2347
3d55596
ebe1bf5
20763ce
64b0082
be829c9
4007671
9b40d91
9e6c11a
f1cc942
6b3fb54
f25e15b
73fe700
94651f8
82b3f02
6bfc029
23556b3
76dd221
6b6be70
311832d
34ef476
5f1732f
b17c354
37ab91e
54395c1
5e5701e
2b16ebb
40276ed
16887f9
c95d8a8
8c4dbf8
22691b4
cfff9b3
a341cfe
16ec0b1
698690f
10f05e6
98fd0e1
021f4f0
d7bca77
f94891c
0664eb1
e4c185b
3af159e
23ddc74
6829b66
b237d0d
555bbd9
fd9626c
403c02a
69cf61b
8e8eea5
6e87398
fb5509e
3ee0f42
705f5b3
2a0829b
53b886a
37cb373
9b88903
5fa5850
03c3974
9aeabb3
07de4e5
39904d0
e4fc2a7
dc2841e
276434d
23de869
d844cd2
ec52d7f
f8a5a66
abda353
e2f2f6a
afa7bdd
de05dd6
3b19233
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider formatting with one condition per line to make it easier to read:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed it while I was looking at the file. It's a very small change, do we really need to open another PR to fix this?
This is valid also for the other small changes unrelated to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not suggesting we need another PR for this... I'm just saying we shouldn't modify files that have nothing at all to do with this PR.
This file can be "cleaned" up some future day when we are doing some work that actually involves this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is your current thinking on this unnecessary diff? Can it be removed from this PR?