Skip to content

CSHARP-5559: Update Microsoft.NET.Test.Sdk to 17.13.0 for s390x compatibility #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

medhatiwari
Copy link
Contributor

@medhatiwari medhatiwari commented Apr 3, 2025

Problem

Tests were aborting with the following error on .NET 8 (especially on non-x86 platforms like s390x):

System.TypeInitializationException: The type initializer for 'Microsoft.VisualStudio.TestPlatform.ObjectModel.Constants' 
threw an exception. ---> System.NotSupportedException: Specified method is not supported. at 
Microsoft.VisualStudio.TestPlatform.PlatformAbstractions.PlatformEnvironment.get_Architecture()

This is caused by an outdated version of Microsoft.NET.Test.Sdk (e.g., 15.8.0), which uses PlatformEnvironment.get_Architecture() — not supported on some platforms.


Resolution

Upgraded Microsoft.NET.Test.Sdk to 17.13.0, the latest stable release as of now, which includes:

The PR fixing this issue was merged on October 12, 2022, and first shipped in version 17.4.0.


Related

  • Fix PR in vstest repo: microsoft/vstest#4066
  • Observed error in MongoDB C# Driver tests (example failure: LoadBalancingIntegrationTests)

@medhatiwari medhatiwari requested a review from a team as a code owner April 3, 2025 09:58
@medhatiwari medhatiwari requested review from JamesKovacs and removed request for a team April 3, 2025 09:58
@medhatiwari medhatiwari changed the title Update Microsoft.NET.Test.Sdk to 17.13.0 for .NET 8 compatibility Update Microsoft.NET.Test.Sdk to 17.13.0 for s390x compatibility Apr 3, 2025
@BorisDog BorisDog requested review from BorisDog and removed request for JamesKovacs April 3, 2025 22:04
@medhatiwari
Copy link
Contributor Author

Hi @BorisDog
Can this be merged?

@BorisDog BorisDog changed the title Update Microsoft.NET.Test.Sdk to 17.13.0 for s390x compatibility CSHARP-5559: Update Microsoft.NET.Test.Sdk to 17.13.0 for s390x compatibility Apr 7, 2025
@sanych-sun sanych-sun added the chore Label to hide PR from generated Release Notes label Apr 7, 2025
@BorisDog BorisDog merged commit cb2fac8 into mongodb:main Apr 7, 2025
94 of 96 checks passed
@BorisDog
Copy link
Contributor

BorisDog commented Apr 7, 2025

Thanks @medhatiwari!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Label to hide PR from generated Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants