CSHARP-4319: FLE - maxWireVersion should run on Mongo Server 4.0.x. #878
Conversation
| @@ -323,7 +323,7 @@ private static int GetMaxWireVersion() | |||
| using (var session = StartSession()) | |||
| using (var binding = CreateReadBinding(session)) | |||
| { | |||
| var command = new BsonDocument("hello", 1); | |||
| var command = new BsonDocument(OppressiveLanguageConstants.LegacyHelloCommandName, 1); | |||
There was a problem hiding this comment.
might be called for servers that support only legacy hello
There was a problem hiding this comment.
Using legacy hello will fail when running tests with apiStrict enabled. Note that hello was backported to earlier versions and is supported on 3.6.21, 4.0.21, 4.2.10, 4.4.2, and 5.0+. (See https://jira.mongodb.org/browse/SERVER-49986 for details.) While hello will fail against earlier patch builds of the server, we only test against latest patch of each version in Evergreen. Thus I don't think we need to make this change.
There was a problem hiding this comment.
hmm, it's strange, I changed this because on server 40 that I launched locally, hello command has failed.. I don't think that I use too old version, but I will try to download newest 40 server version and check again
There was a problem hiding this comment.
you're correct. It looks like my local version for 40 server was too old, reverted
| @@ -323,7 +323,7 @@ private static int GetMaxWireVersion() | |||
| using (var session = StartSession()) | |||
| using (var binding = CreateReadBinding(session)) | |||
| { | |||
| var command = new BsonDocument("hello", 1); | |||
| var command = new BsonDocument(OppressiveLanguageConstants.LegacyHelloCommandName, 1); | |||
There was a problem hiding this comment.
Using legacy hello will fail when running tests with apiStrict enabled. Note that hello was backported to earlier versions and is supported on 3.6.21, 4.0.21, 4.2.10, 4.4.2, and 5.0+. (See https://jira.mongodb.org/browse/SERVER-49986 for details.) While hello will fail against earlier patch builds of the server, we only test against latest patch of each version in Evergreen. Thus I don't think we need to make this change.
No description provided.