CXX-3101 Remove workarounds for core::string_view #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3101. Verified by
this patchthis patch.Following #1257, workarounds that were required for mnmlstc/core
string_viewcompatibility are no longer necessary.These former workarounds primarily consist of the lack of equality comparison operators against string literals (fixed in mnmlstc/core@776eb3e but never released) and broken hash algorithm (fixed in mnmlstc/core@42a34a9 but never released). The changes in this PR address workarounds for the equality comparison operators only. We've opted to completely avoid hashing of
string_viewup to this point (e.g. see #935 (comment)). Refactoring existing workarounds to usestring_viewinstead is not as straightforward (due to lifetime/dangling concerns) and thus deferred.