CXX-3077 BSON Binary Vector accessor, sub_binary builder #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eramongodb
requested changes
Mar 21, 2025
.evergreen/config_generator/components/funcs/install_c_driver.py
Outdated
Show resolved
Hide resolved
mdbmes
commented
Mar 22, 2025
.evergreen/config_generator/components/funcs/install_c_driver.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Ezra Chung <[email protected]>
This reverts commit 3422b2e.
….hpp Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
eramongodb
approved these changes
Mar 27, 2025
src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/vector/formats-fwd.hpp
Outdated
Show resolved
Hide resolved
src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/vector/accessor.hpp
Outdated
Show resolved
Hide resolved
src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/vector/accessor.hpp
Outdated
Show resolved
Hide resolved
src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/vector/elements.hpp
Outdated
Show resolved
Hide resolved
src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/vector/elements.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
mdbmes
changed the title
mdbmes
changed the title
kevinAlbs
reviewed
Apr 1, 2025
src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/vector/iterators.hpp
Outdated
Show resolved
Hide resolved
kevinAlbs
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation of CXX-3077, adding
bsoncxxsupport for the BSON Binary Vector specification.The main contribution in this PR is to add the
bsoncxx::vectornamespace, and especially thebsoncxx::vector::accessortemplate. A vector accessor can wrap any validatedb_binaryvalue as read-only, or a mutable accessor can be obtained during append.General binary items can now be created and edited in-place during an append, using a new
sub_binarybasic builder.Bumps the Libmongoc version to an unreleased pre-2.0.0 snapshot, to get access to new Libbson features:
bson_append_binary_uninit,bson_vector_*_const_view_init, andbson_vector_*_binary_data_length. Validation for existing and newly allocated vectors has been delegated to Libbson, to reuse as much of its testing as possible. The actual vector accessor template in bsoncxx has been implemented in a way similar to Libbson's vector views, but without a direct dependency.This implementation is currently less comprehensive than the Libbson implementation for BSON Binary Vector. No support is included for conversion between BSON arrays and BSON vectors, and there are no functions for bulk element conversion. Instead, a standard iterator interface allows access to individual elements or element ranges.
The spec includes JSON tests that are similar to bson_corpus. As with bsoncxx's approach to bson_corpus, this PR chooses to delegate those tests to the underlying Libbson implementation.