GODRIVER-2736 Deprecate currentOp/collStats commands #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Jun 2, 2023
blink1073
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2736
Summary
GODRIVER-2384 added
These files do not have analogues in the unified-test-format/tests/valid-pass directory. Since 2384 syncs to the specifications PR #959, it appears that (given the 3rd point on the PR description) the proposed renaming of these files was dismissed. However, the Go Driver persisted the change. This PR reverts the names of the tests above to
This PR also reverts the "collectionOptions" tags for "collectionData" to "createOptions," putting the struct inline with specifications: https://github.com/mongodb/specifications/blob/9e770b54bbb6315aa82a162c42c577a5b3f8037a/source/unified-test-format/unified-test-format.rst#collectiondata
Background & Motivation
collStats and currentOp will produce a deprecation message in 6.0 and are candidates for removal in another major release. Consumers of the API should switch to using an aggregation pipeline containing a single stage of the same name as the deprecated command.