Skip to content

GODRIVER-2384 Unified test runner changes for CSOT. #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 20, 2022
Merged

GODRIVER-2384 Unified test runner changes for CSOT. #912

merged 9 commits into from
Apr 20, 2022

Conversation

benjirewis
Copy link
Contributor

GODRIVER-2384

Updates the unified test runner to support functionality that will be introduced with the merging of this PR. These test runner updates should allow me to start running the CSOT spec tests in subsequent PRs.

Syncs valid-pass tests (POC tests that should pass in the unified test runner). Adds support for specifying collectionOptions in initialData, using the iterateOnce operation on cursor entities, using $$lte as a special matching operator, and using the createEntities operation on the test runner.

I did not sync the invalid tests, as we don't currently have a way of running those in the Go driver. I also did not add the new isTimeoutError assertion, as that relies on CSOT changes not yet in the driver.

Copy link
Member

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, it really helps clear up our discussions about adding data to unified tests! I left one suggestion but it's purely subjective.

Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review. This is looking good. Left a few suggested changes.

@benjirewis benjirewis requested a review from kevinAlbs April 19, 2022 21:53
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benjirewis benjirewis merged commit f195b4e into mongodb:master Apr 20, 2022
@benjirewis benjirewis deleted the csotUTFChanges.2384 branch April 20, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants