-
Notifications
You must be signed in to change notification settings - Fork 906
GODRIVER-2384 Unified test runner changes for CSOT. #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, it really helps clear up our discussions about adding data to unified tests! I left one suggestion but it's purely subjective.
data/unified-test-format/valid-pass/initialCollectionData-collectionOptions.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late review. This is looking good. Left a few suggested changes.
data/unified-test-format/valid-pass/initialCollectionData-collectionOptions.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
GODRIVER-2384
Updates the unified test runner to support functionality that will be introduced with the merging of this PR. These test runner updates should allow me to start running the CSOT spec tests in subsequent PRs.
Syncs valid-pass tests (POC tests that should pass in the unified test runner). Adds support for specifying
collectionOptions
ininitialData
, using theiterateOnce
operation on cursor entities, using$$lte
as a special matching operator, and using thecreateEntities
operation on the test runner.I did not sync the
invalid
tests, as we don't currently have a way of running those in the Go driver. I also did not add the newisTimeoutError
assertion, as that relies on CSOT changes not yet in the driver.