-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add in operator to Atlas Search #1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c248c73
wip
joykim1005 b6c0b98
update with Evergreen test
joykim1005 6235698
Merge branch 'main' into JAVA-5744
joykim1005 318e55a
fix doc
joykim1005 cd1f0b7
merge conflict
joykim1005 503a556
fix
joykim1005 b404175
fix
joykim1005 2e31990
fix checkstyle
joykim1005 71bab54
Merge branch 'main' into JAVA-5744
joykim1005 42da7af
Stop manually encoding UUIDs
stIncMale 65840eb
PR fixes
katcharov aa39619
Update driver-core/src/main/com/mongodb/client/model/search/SearchOpe…
katcharov 44c43e1
PR fixes
katcharov fc05d29
Merge remote-tracking branch 'upstream/main' into JAVA-5744
katcharov d0dfa2b
Post-merge fixes
katcharov ec1e713
Update driver-core/src/main/com/mongodb/client/model/search/SearchOpe…
katcharov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
driver-core/src/main/com/mongodb/client/model/search/InSearchOperator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright 2008-present MongoDB, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.mongodb.client.model.search; | ||
|
||
import com.mongodb.annotations.Beta; | ||
import com.mongodb.annotations.Reason; | ||
import com.mongodb.annotations.Sealed; | ||
import org.bson.types.ObjectId; | ||
|
||
import java.time.Instant; | ||
import java.util.UUID; | ||
|
||
/** | ||
* @see SearchOperator#in(FieldSearchPath, boolean, boolean...) | ||
* @see SearchOperator#in(FieldSearchPath, ObjectId, ObjectId...) | ||
* @see SearchOperator#in(FieldSearchPath, Number, Number...) | ||
* @see SearchOperator#in(FieldSearchPath, Instant, Instant...) | ||
* @see SearchOperator#in(FieldSearchPath, UUID, UUID...) | ||
* @see SearchOperator#in(FieldSearchPath, String, String...) | ||
* @see SearchOperator#in(FieldSearchPath, Iterable) | ||
* @since 5.3 | ||
*/ | ||
@Sealed | ||
@Beta(Reason.CLIENT) | ||
public interface InSearchOperator extends SearchOperator { | ||
@Override | ||
InSearchOperator score(SearchScore modifier); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is based on
static DateRangeSearchOperatorBase dateRange(final FieldSearchPath path, final FieldSearchPath... paths)
Having two params ensures that the user is unable to provide zero values. I am not sure we should do this even there, but I think in this case, we should not have both of these params, but just the values, since the docs did not seem to exclude empty lists. (Note that the docs on values seem to be incorrect)
@stIncMale cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check if the server actually allows passing
value: []
.in(final FieldSearchPath path, final ObjectId value, final ObjectId... values)
. We may follow that with adding another thing to be re-reviewed to JAVA-5752: Re-visit some aspects of the Atlas search API design before moving it out of betavalue: []
, then we should rather introducein(final FieldSearchPath path, final ObjectId... values)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not allow. See https://search-playground.mongodb.com/tools/code-sandbox/snapshots/6793c3ebe68ae0bae860e843
Added comment to 5752