Skip to content

Disable align_multiline_parameters in .editorconfig #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

stIncMale
Copy link
Member

Not only this setting is ignored by IDEA when the alignment has to change
as a result of parameter/type/method name change,
but also it leaves much less space for a parameter till the end of line.

Generally, having any alignment that is based not on the line start & nesting level,
but on a specific position in the text on the previous line is neither enforceable
nor a good idea, because it results in spending too much time trying to align the code.

Not only this setting is ignored by IDEA when the alignment has to change
as a result of parameter/type/method name change,
but also it leaves much less space for a parameter till the end of line.

Generally, having any alignment that is based not on the line start & nesting level,
but on a specific position in the text on the previous line is neither enforceable
nor a good idea, because it results in spending too much time trying to align the code.
@stIncMale stIncMale requested review from jyemin and rozza June 30, 2021 16:39
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stIncMale stIncMale merged commit b10f30c into mongodb:master Jul 2, 2021
@stIncMale stIncMale deleted the update_editorconfig branch July 2, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants