Skip to content

PHPC-2571 Import BulkWrite tests for Client BulkWriteCommand #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

PHPC-2571 Import BulkWrite tests for Client BulkWriteCommand #1819

merged 2 commits into from
Apr 17, 2025

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Apr 16, 2025 •
edited
Loading

Fix PHPC-2571

GromNaN
GromNaN commented Apr 16, 2025
View reviewed changes
Copy link
Member Author

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alcaeus I spotted differences between existing collection BulkWrite and the new client BulkWiteCommand. I need your opinion wether we converge to the same behavior or we keep things different for good reasons.

@GromNaN GromNaN mentioned this pull request Apr 16, 2025
Draft
2 tasks
@GromNaN
Copy link
Member Author

GromNaN commented Apr 17, 2025

Changes:

Since UTF-8 validation is already broken, there are requests to disable, validation negatively impacts performance, and it is not a spec requirement, this PR excludes default validation in MongoClient.bulkWrite.

  • Use the $set operator for every updateOne tests what were passing a document directly.
  • Update the tests for the new exception class and message

@GromNaN GromNaN marked this pull request as ready for review April 17, 2025 08:19
@GromNaN GromNaN requested a review from a team as a code owner April 17, 2025 08:19
@GromNaN GromNaN requested review from alcaeus and removed request for a team April 17, 2025 08:20
GromNaN
GromNaN commented Apr 17, 2025
View reviewed changes
tests/bulkwritecommand/bulkwritecommand-insertone-001.phpt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is replaced by bulkwritecommand-insertOne-004.phpt

@GromNaN GromNaN merged commit e3fa20c into mongodb:feature/client-bulk-write Apr 17, 2025
60 checks passed
@GromNaN GromNaN deleted the PHPC-2571 branch April 17, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @alcaeus