Fix refs used for code scanning results #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Jun 14, 2024
|
I'll have to revisit this as apparently just passing the |
alcaeus
force-pushed
the
fix-sarif-release-upload
branch
3 times, most recently
from
aeacaf8 to
849fe0e
Compare
alcaeus
force-pushed
the
fix-sarif-release-upload
branch
from
849fe0e to
155bd70
Compare
alcaeus
commented
Jun 17, 2024
| sha: ${{ github.event_name == 'workflow_dispatch' && env.CHECKED_OUT_SHA || github.sha }} | ||
|
|
||
| - name: "Upload SARIF report" | ||
| if: ${{ github.event_name != 'workflow_dispatch' }} |
There was a problem hiding this comment.
I needed to split this, as the upload-sarif action contains logic to fix the refs/pulls/<number>/merge ref, but doesn't do so when it was provided explicitly. Thus the only way to retain current logic for pull requests is to invoke the action without ref and sha arguments, and then explicitly pass them when the workflow was dispatched manually.
alcaeus
force-pushed
the
fix-sarif-release-upload
branch
from
155bd70 to
f7bb2a6
Compare
jmikola
approved these changes
Jun 17, 2024
|
Note: ignored failing evergreen variants, as they're related to a newer PHPC version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes here:
github.refvariable is set to the branch that the release workflow was triggered in. This is changed to the tag reference we just created.github.ref, which was also changed to using the ref of the newly created tag.