Skip to content

PHPLIB-652: Convert change streams to unified test format #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Apr 1, 2022

https://jira.mongodb.org/browse/PHPLIB-652
https://jira.mongodb.org/browse/PHPLIB-828
https://jira.mongodb.org/browse/PHPLIB-829

This bumps the supported schema version to 1.7, but omits support for 1.6 (see: PHPLIB-718). Additionally, this introduces support for Collection::rename(), which is relevant to PHPLIB-828.

Depends on #909

@jmikola jmikola force-pushed the phplib-652 branch 3 times, most recently from 7f3396d to b344ce2 Compare April 12, 2022 16:32
@jmikola jmikola requested a review from aleksandr-rudo April 12, 2022 16:33
@jmikola jmikola marked this pull request as ready for review April 12, 2022 16:33
jmikola added 2 commits April 12, 2022 12:49
This bumps the supported schema version to 1.7, but omits support for 1.6 (see: PHPLIB-718).

Also includes spec tests for PHPLIB-828 and PHPLIB-829 and introduces support for Collection::rename() operation.

Change stream tests synced with mongodb/specifications@bb7a784.

Unified spec tests synced with mongodb/specifications@ff0c705.
@jmikola
Copy link
Member Author

jmikola commented Apr 14, 2022

Note: I asked in #driver-devs in anyone else had experienced test failures on a sharded cluster due to a "drop" event appearing in the change stream instead of an "insert". Related tests I observed this in:

PHPLIB task failures (server version 5.0.6): first failure, second.

The unexpected drop is most certainly coming from initialData in the spec test file, which clears the one collection under test, but I've never seen this before. The errors are also intermittent, and disappeared when restarting the builds.

If this comes up again after merging, I will create a separate PHPLIB ticket to investigate and add the failing-on-waterfall label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants