PYTHON-4409 Streamline Wheel Building #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibola
approved these changes
Apr 30, 2024
Comment on lines
-39
to
-52
| python: ["cp37", "cp38", "cp39", "cp310", "cp311", "cp312"] | ||
| include: | ||
| - buildplat: [macos-11, macosx_*] | ||
| python: "cp37" | ||
| - buildplat: [macos-11, macosx_*] | ||
| python: "cp38" | ||
| - buildplat: [macos-11, macosx_*] | ||
| python: "cp39" | ||
| - buildplat: [macos-14, macosx_*] | ||
| python: "cp310" | ||
| - buildplat: [macos-14, macosx_*] | ||
| python: "cp311" | ||
| - buildplat: [macos-14, macosx_*] | ||
| python: "cp312" |
There was a problem hiding this comment.
Why can we get away with not specifying the python version anymore Is It that the way we build wheels now will automatically create wheels packages for 3.7 - 3.12?
There was a problem hiding this comment.
Yes, and we verify it later. :)
Comment on lines
+66
to
+68
| - name: Build wheels | ||
| env: | ||
| CIBW_BUILD: ${{ matrix.python }}-${{ matrix.buildplat[1] }} | ||
| MACOS_TEST_SKIP: "*arm64" | ||
| CIBW_BUILD: ${{ matrix.buildplat[2] }} |
There was a problem hiding this comment.
Should this step exclude manylinux1?
There was a problem hiding this comment.
No need to exclude it. We have a separate manylinux1 to ensure that we have wheels that include that arch, but it is fine if we have duplicate wheels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.