Skip to content

PYTHON-5134 Fix binary installation and remove unused scripts #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 13, 2025

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 12, 2025

@blink1073 blink1073 requested a review from NoahStapp February 12, 2025 18:52
@NoahStapp
Copy link
Contributor

Lots of windows failures with .evergreen/scripts/setup-dev-env.sh: line 35: /data/mci/91032c40373a5ca1631cee8358db6ace/drivers-tools/.bin/uv: Permission denied: https://evergreen.mongodb.com/task_log_raw/mongo_python_driver_test_win64_python3.9_test_6.0_sharded_cluster_auth_ssl_async_patch_9a7bac7d4512bd2450e5b2609b3629f013d2cd5c_67acedd298ad5c00076c0f29_25_02_12_18_52_03/0?type=T

@blink1073
Copy link
Member Author

Weird, not sure what caused that... I sure do love path issues on Windows...

@blink1073
Copy link
Member Author

Fixed. uv had a release last night. I suspect the files were no longer executable.

@NoahStapp
Copy link
Contributor

Can we split the consolidation and removal of unused scripts into a separate PR?

@blink1073
Copy link
Member Author

Can we split the consolidation and removal of unused scripts into a separate PR?

I needed the consolidation in order to move the handling of TMPDIR, which was the primary failure. I don't think restoring the other unused scripts is worth the effort to recreate the files in this PR.

@blink1073
Copy link
Member Author

Actually they were separate commits, I can undo them.

@blink1073
Copy link
Member Author

Nevermind, the commit was intertwined and reverting it caused a conflict.

Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you update the title to reflect the cleanups that happen in here as well?

@blink1073 blink1073 changed the title PYTHON-5134 Fix AWS ECS just installation PYTHON-5134 Fix AWS ECS just installation and remove unused scripts Feb 13, 2025
@blink1073 blink1073 changed the title PYTHON-5134 Fix AWS ECS just installation and remove unused scripts PYTHON-5134 Fix binary installation and remove unused scripts Feb 13, 2025
@blink1073 blink1073 merged commit 3e29671 into mongodb:master Feb 13, 2025
42 of 46 checks passed
@blink1073 blink1073 deleted the PYTHON-5134 branch February 13, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants