-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5138 Convert setup_tests.py to a cli #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give this man a medal. A few minor comments, but overall looks great!
test_func = FunctionCall(func="run tests", vars=test_vars) | ||
tasks.append(EvgTask(name=name, tags=tags, commands=[bootstrap_func, test_func])) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional whitespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
@@ -2,5 +2,5 @@ | |||
set -eu | |||
HERE=$(dirname ${BASH_SOURCE:-$0}) | |||
. $HERE/env.sh | |||
SUCCESS=false TEST_FLE_GCP_AUTO=1 bash $HERE/setup-tests.sh | |||
./.evergreen/just.sh setup-test kms gcp-fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the use of ./.evergreen/just.sh
instead of bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh
intentional here? It would be nice to use a consistent way of invoking our test cli across test suites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These scripts are going away in subsequent PRs.
OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ | ||
bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh setup-test | ||
bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh test-eg | ||
OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ | |
OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, the UI won't let me accept the suggestion, will apply these manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, this indent was intentional, and like I said, this script is going away.
bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh setup-test | ||
bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh test-eg | ||
OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ | ||
bash scripts/setup-tests.sh ocsp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bash scripts/setup-tests.sh ocsp | |
bash scripts/setup-tests.sh ocsp |
pushd "$(dirname "$(dirname $HERE)")" > /dev/null | ||
HERE="$( cd -- "$HERE" > /dev/null 2>&1 && pwd )" | ||
ROOT=$(dirname "$(dirname $HERE)") | ||
pushd $ROOT > /dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing matching popd
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
I need to debug why a couple of the tests timed out. |
Ah, we weren't properly handling NO_EXT before. I'll have to split those tests into sync and async. |
Passing build: https://spruce.mongodb.com/version/67b75da9b482ad000730db61/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC