PYTHON-1787: fix NotMasterError wrong attribute error #450
Conversation
pymongo/errors.py
Outdated
| @@ -114,7 +114,7 @@ class NotMasterError(AutoReconnect): | |||
| Subclass of :exc:`~pymongo.errors.AutoReconnect`. | |||
| """ | |||
| def __str__(self): | |||
There was a problem hiding this comment.
As discussed earlier today, can you add a test that asserts that the "full error" string is included in str(exc) and traceback.format_exc()?
test/test_monitoring.py
Outdated
| @@ -439,6 +439,9 @@ def test_not_master_error(self): | |||
| client.pymongo_test.test.find_one_and_delete({}) | |||
| except NotMasterError as exc: | |||
| error = exc.errors | |||
| import traceback | |||
| self.assertIn("full error", str(exc)) | |||
| self.assertIn("full error", traceback.format_exc()) | |||
There was a problem hiding this comment.
This is exactly what I had in mind. What do you think about moving these assertions to their own test cases (maybe to a new file test_errors.py)? You can use the error classes directly, like:
exc = NotMasterError(...)
self.assertIn("full error", str(exc))
try:
raise exc
except NotMasterError:
self.assertIn("full error", traceback.format_exc())
test/test_errors.py
Outdated
| try: | ||
| raise exc | ||
| except NotMasterError: | ||
| import traceback |
There was a problem hiding this comment.
Can you move this import to the top of the file?
test/test_errors.py
Outdated
|
|
||
| class TestErrors(PyMongoTestCase): | ||
| def test_not_master_error(self): | ||
| exc = NotMasterError("not master test", "details") |
There was a problem hiding this comment.
Suggest using something like {ok: 0, errmsg:"error"} instead of "details".
| unittest) | ||
|
|
||
| class TestErrors(PyMongoTestCase): | ||
| def test_not_master_error(self): |
There was a problem hiding this comment.
Can you also add a similar test for OperationFailure?
test/test_errors.py
Outdated
| @@ -0,0 +1,18 @@ | |||
| from pymongo.errors import (AutoReconnect, | |||
There was a problem hiding this comment.
Add the copyright notice # Copyright 2020-present MongoDB, Inc. ....
test/test_errors.py
Outdated
| @@ -0,0 +1,18 @@ | |||
| from pymongo.errors import (AutoReconnect, | |||
There was a problem hiding this comment.
After importing standard python libraries but before importing pymongo can you add sys.path[0:0] = [""]. For example:
mongo-python-driver/test/test_bson.py
Line 27 in 4760d07
| raise exc | ||
| except NotMasterError: | ||
| import traceback | ||
| self.assertIn("full error", traceback.format_exc()) |
There was a problem hiding this comment.
Can you add the if __name__ == "__main__": logic at the bottom of this file?
mongo-python-driver/test/test_bson.py
Lines 1088 to 1089 in 4760d07
| client_knobs, | ||
| PyMongoTestCase, | ||
| sanitize_cmd, | ||
| unittest) |
There was a problem hiding this comment.
Suggest removing any unused imports.
juliusgeo
changed the title
juliusgeo
changed the title
pymongo/errors.py
Outdated
| @@ -114,7 +114,7 @@ class NotMasterError(AutoReconnect): | |||
| Subclass of :exc:`~pymongo.errors.AutoReconnect`. | |||
| """ | |||
| def __str__(self): | |||
| client_knobs, | ||
| PyMongoTestCase, | ||
| sanitize_cmd, | ||
| unittest) |
| unittest) | ||
|
|
||
| class TestErrors(PyMongoTestCase): | ||
| def test_not_master_error(self): |
| raise exc | ||
| except NotMasterError: | ||
| import traceback | ||
| self.assertIn("full error", traceback.format_exc()) |
This is fixing the issue from the previous pull request which was caused by NotMasterError failing
https://jira.mongodb.org/browse/PYTHON-1787